Fix robustness across gitdm tools: NameError, LogPatchSplitter call, CSV column shape, pickling modes, and guarded pdb #916
+10
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…anging outputs - reports.py: fix NameError in ReportByReports (use `reported` instead of undefined `report`). - gitdm.py: pass default date range to LogPatchSplitter to match current API and avoid TypeError. - database.py: include `source` column for alias rows in AllAffsCSV to keep CSV shape consistent. - committags.py: write pickle in binary mode (wb) for compatibility. - linetags.py: read pickle in binary mode (rb) for compatibility. - cncfdm.py: avoid unconditional pdb on missing affiliation; only break into debugger with -X, otherwise log and continue. These are no-op for normal outputs except: AllAffsCSV alias rows now include the `source` column as intended. Signed-off-by: Shubham Shukla <shubhushukla586@gmail.com>
Contributor
Author
Hey Łukasz, I’ve fixed all the issues, bugs, and improvements I could find in the repo, and I’ll continue contributing whenever I spot more. I just wanted to ask, if there are any features you’d like to add, or any medium-level issues/help-wanted tasks, feel free to let me know. I really enjoy working on this project and would be happy to take them up and help further. |
Member
|
Hi, thanks for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and fixes to data handling and output formatting across multiple scripts, primarily focused on ensuring compatibility with binary file operations, improving error handling, and enhancing output data completeness.
File handling and compatibility improvements:
committags.dbto use binary mode ('wb'and'rb') in bothsrc/committags.pyandsrc/linetags.py, ensuring compatibility with Python 3'spicklemodule requirements. [1] [2]Error handling and debugging:
src/cncfdm.py, improved handling of missing affiliations by conditionally invoking the debugger only ifDebugHaltis set; otherwise, a descriptive error message is written tostderrand the entry is skipped.Output and data completeness:
AllAffsCSV(src/database.py) to include thesourcefield, providing more comprehensive data in each row.Default behavior and consistency:
logparser.LogPatchSplitterinsrc/gitdm.pyto match the wide-open range used incncfdm.py, ensuring consistent patch processing across scripts.…anging outputsreportedinstead of undefinedreport).sourcecolumn for alias rows in AllAffsCSV to keep CSV shape consistent.These are no-op for normal outputs except: AllAffsCSV alias rows now include the
sourcecolumn as intended.