generated from cobaltcore-dev/repository-template
-
Notifications
You must be signed in to change notification settings - Fork 0
Schedule commitments with new reservations operator & crd #249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7cea4bb to
0d5ccf1
Compare
f66e309 to
e7b189c
Compare
c70ad87 to
a20c7a1
Compare
SoWieMarkus
approved these changes
Aug 20, 2025
internal/scheduler/nova/plugins/shared/filter_has_enough_capacity.go
Outdated
Show resolved
Hide resolved
e597503 to
ca9eb18
Compare
SoWieMarkus
approved these changes
Aug 21, 2025
537f9a0 to
4f6fce2
Compare
c360a71 to
fecc5ab
Compare
9dffe0d to
c6e8f3d
Compare
c6e8f3d to
72152a1
Compare
SoWieMarkus
approved these changes
Aug 27, 2025
Co-authored-by: Markus Wieland <44964229+SoWieMarkus@users.noreply.github.com>
Contributor
Test Coverage ReportCoverage in main module (internal/): 76.0%Coverage in reservations module (reservations/internal/): 51.3% |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change summary
Reservations operator
ComputeReservationresources for them. They are distinguished byinstanceorbarereservations.instancereservations and tries to place them on a host using the initial placement pipeline. If the placement succeeds, the reservation is consideredactive.instancereservations that don't match the hypervisor type are put into a terminalfailedstate.barereservations into a terminalfailedstate as we don't know yet how to handle these reservations and generate initial placement requests for them.Cortex core
CI/CD
Tilt setup