Skip to content

Conversation

@skobyda
Copy link
Contributor

@skobyda skobyda commented Jun 9, 2022

@skobyda skobyda requested review from garrett, martinpitt and marusak June 9, 2022 09:02
@skobyda
Copy link
Contributor Author

skobyda commented Jun 9, 2022

This PR is a clone of #533, after I accidentally closed it :)

Copy link
Member

@martinpitt martinpitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@skobyda skobyda requested a review from martinpitt June 9, 2022 10:07
Copy link
Member

@martinpitt martinpitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers!

Copy link
Member

@garrett garrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! I can approve this, as this PR isn't one I opened! 😉

I rewrote the text a while back on the original PR and it shows up here. It still looks fine to me. I'm happy if anyone can find some issues we can fix, of course. But I'm fine with it as-is. Screenshot looks fine too.

It passes the checklist as well: Links have been updated and summary has been added.

👍

@martinpitt martinpitt merged commit 6ddabf4 into cockpit-project:main Jun 9, 2022
@skobyda skobyda deleted the 271 branch July 26, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants