Skip to content

Conversation

@rmloveland
Copy link
Contributor

Fixes DOC-10998

@netlify
Copy link

netlify bot commented Sep 9, 2025

Deploy Preview for cockroachdb-interactivetutorials-docs canceled.

Name Link
🔨 Latest commit a8c9f36
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-interactivetutorials-docs/deploys/68c32b07740f39000896d614

@netlify
Copy link

netlify bot commented Sep 9, 2025

Deploy Preview for cockroachdb-api-docs canceled.

Name Link
🔨 Latest commit a8c9f36
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-api-docs/deploys/68c32b07232fba000814a803

@github-actions
Copy link

github-actions bot commented Sep 9, 2025

@netlify
Copy link

netlify bot commented Sep 9, 2025

Netlify Preview

Name Link
🔨 Latest commit a8c9f36
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-docs/deploys/68c32b07ebcc200009c4fdaf
😎 Deploy Preview https://deploy-preview-20313--cockroachdb-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

@jbowens jbowens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@rmloveland rmloveland requested a review from taroface September 11, 2025 15:05
Copy link
Contributor

@taroface taroface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one small question

Fixes DOC-10998

NB. Ported changes to supported versions v24.1+
@rmloveland rmloveland force-pushed the 20250909-DOC-10998-wal-dir-is-hardcoded branch from 7011271 to 7adad60 Compare September 11, 2025 20:02
@rmloveland rmloveland enabled auto-merge (squash) September 11, 2025 20:03
@rmloveland
Copy link
Contributor Author

backporting to supported versions v24.1+

@rmloveland rmloveland merged commit e65a322 into main Sep 11, 2025
6 checks passed
@rmloveland rmloveland deleted the 20250909-DOC-10998-wal-dir-is-hardcoded branch September 11, 2025 20:29
@rmloveland rmloveland restored the 20250909-DOC-10998-wal-dir-is-hardcoded branch September 12, 2025 14:43
@rmloveland rmloveland deleted the 20250909-DOC-10998-wal-dir-is-hardcoded branch September 12, 2025 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants