-
Notifications
You must be signed in to change notification settings - Fork 477
Add callouts for S3-compatible storage support policy #20503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| {% if page.path contains "cockroachcloud" %} | ||
| {{ site.data.alerts.callout_danger }} | ||
| Cockroach Labs does not officially support S3-compatible storage solutions other than AWS S3, Google Cloud Storage (GCS), and Azure Blob Storage. Some common compatibility issues may be fixed by adding the `AWS_SKIP_CHECKSUM` option to the S3 URLs. | ||
|
|
||
| The [Cockroach Labs Support team]({% link {{ site.current_cloud_version }}/support-resources.md %}) is available to offer assistance where possible. If you encounter issues when using unsupported S3-compatible storage, drivers, or frameworks, contact the maintainer directly. | ||
| {{ site.data.alerts.end }} | ||
| {% else %} | ||
| {{ site.data.alerts.callout_danger }} | ||
| Cockroach Labs does not officially support S3-compatible storage solutions other than AWS S3, Google Cloud Storage (GCS), and Azure Blob Storage.{% if page.version.version !="v24.1" %} Some common compatibility issues may be fixed by adding the `AWS_SKIP_CHECKSUM` option to the S3 URLs.{% endif %}. | ||
|
|
||
|
|
||
| The [Cockroach Labs Support team]({% link {{page.version.version}}/support-resources.md %}) is available to offer assistance where possible. If you encounter issues when using unsupported S3-compatible storage, drivers, or frameworks, contact the maintainer. | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this language is a lot better. could you provide a preview web page so i can understand how this renders? There are several repeat lines in this page, but maybe it renders nicely.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sure thing, here's how it renders - https://deploy-preview-20503--cockroachdb-docs.netlify.app/docs/stable/backup-and-restore-overview#backup-storage The repeat lines are because I'm using some in-page logic to slightly adjust the text based on which page it's on. For the v24.1 version of the page, exclude the line about
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. For ease of review on docs PRs, about ~10 minutes after a commit to a docs PR is pushed, there should be a comment automatically posted by Netlify that (if successful) includes a link to a render preview of the PR. Just FYI for future reference. |
||
| {{ site.data.alerts.end }} | ||
| {% endif %} | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This language looks good! Thanks for the update.
Nit: remove the double period at the end of this sentence (after the
option to S3 URLsbit).