-
Notifications
You must be signed in to change notification settings - Fork 477
Updated v20.1 Spring-JPA tutorial to use CRDB Hibernate dialect #7918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
76f99c4 to
afb64b4
Compare
lnhsingh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @ericharmeling, @lnhsingh, and @rafiss)
v20.1/build-a-spring-app-with-cockroachdb-jpa.md, line 88 at r1 (raw file):
The [Hibernate CockroachDB dialect](https://in.relation.to/2020/07/27/hibernate-orm-5419-final-release/) is supported in Hibernate v5.4.19+. At the time of writing this tutorial, Spring Data JPA used Hibernate v5.4.15 as its default JPA provider. To specify a different version of Hibernate than the default, add an additional entry to your application's `pom.xml` file, as shown in [the `roach-data` GitHub repo](https://github.com/cockroachlabs/roach-data/blob/master/roach-data-jpa/pom.xml): ~~~ xml
This code block renders weird because it's in the callout. Though not ideal, maybe you can preface the note and code block with a "Note:" or "It should be noted that the Hibernate..."
v20.2/build-a-spring-app-with-cockroachdb-jpa.md, line 86 at r1 (raw file):
{{site.data.alerts.callout_info}} The [Hibernate CockroachDB dialect](https://in.relation.to/2020/07/27/hibernate-orm-5419-final-release/) is supported in Hibernate v5.4.19+. At the time of writing this tutorial, Spring Data JPA used Hibernate v5.4.15 as its default JPA provider. To specify a different version of Hibernate than the default, add an additional entry to your application's `pom.xml` file, as shown in [the `roach-data` GitHub repo](https://github.com/cockroachlabs/roach-data/blob/master/roach-data-jpa/pom.xml):
Same as above
afb64b4 to
3e79607
Compare
ericharmeling
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TFTR @lnhsingh !
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @lnhsingh and @rafiss)
v20.1/build-a-spring-app-with-cockroachdb-jpa.md, line 88 at r1 (raw file):
Previously, lnhsingh (Lauren Hirata Singh) wrote…
This code block renders weird because it's in the callout. Though not ideal, maybe you can preface the note and code block with a "Note:" or "It should be noted that the Hibernate..."
Removed the note callout.
v20.2/build-a-spring-app-with-cockroachdb-jpa.md, line 86 at r1 (raw file):
Previously, lnhsingh (Lauren Hirata Singh) wrote…
Same as above
Done.
Fixes #5992.
Before merging this, I need to merge the change to the roach-data repo: cockroachlabs/roach-data#4.