Skip to content

Conversation

@ericharmeling
Copy link
Contributor

Fixes #5992.

  • Updated properties file to specify v20.1 CRDB Hibernate dialect.
  • Added latest Hibernate version to pom.xml file (Spring Data JPA uses older version that doesn't support CRDB dialect.
  • Updated app output.

Before merging this, I need to merge the change to the roach-data repo: cockroachlabs/roach-data#4.

@ericharmeling ericharmeling requested a review from rafiss August 3, 2020 19:56
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@cockroach-teamcity
Copy link
Member

@ericharmeling ericharmeling requested a review from lnhsingh August 13, 2020 18:27
Copy link
Contributor

@lnhsingh lnhsingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @ericharmeling, @lnhsingh, and @rafiss)


v20.1/build-a-spring-app-with-cockroachdb-jpa.md, line 88 at r1 (raw file):

The [Hibernate CockroachDB dialect](https://in.relation.to/2020/07/27/hibernate-orm-5419-final-release/) is supported in Hibernate v5.4.19+. At the time of writing this tutorial, Spring Data JPA used Hibernate v5.4.15 as its default JPA provider. To specify a different version of Hibernate than the default, add an additional entry to your application's `pom.xml` file, as shown in [the `roach-data` GitHub repo](https://github.com/cockroachlabs/roach-data/blob/master/roach-data-jpa/pom.xml):

~~~ xml

This code block renders weird because it's in the callout. Though not ideal, maybe you can preface the note and code block with a "Note:" or "It should be noted that the Hibernate..."


v20.2/build-a-spring-app-with-cockroachdb-jpa.md, line 86 at r1 (raw file):

{{site.data.alerts.callout_info}}
The [Hibernate CockroachDB dialect](https://in.relation.to/2020/07/27/hibernate-orm-5419-final-release/) is supported in Hibernate v5.4.19+. At the time of writing this tutorial, Spring Data JPA used Hibernate v5.4.15 as its default JPA provider. To specify a different version of Hibernate than the default, add an additional entry to your application's `pom.xml` file, as shown in [the `roach-data` GitHub repo](https://github.com/cockroachlabs/roach-data/blob/master/roach-data-jpa/pom.xml):

Same as above

@ericharmeling ericharmeling force-pushed the spring-jpa-hibernate-dialect branch from afb64b4 to 3e79607 Compare August 17, 2020 13:59
@ericharmeling ericharmeling requested a review from lnhsingh August 17, 2020 14:00
Copy link
Contributor Author

@ericharmeling ericharmeling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TFTR @lnhsingh !

Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @lnhsingh and @rafiss)


v20.1/build-a-spring-app-with-cockroachdb-jpa.md, line 88 at r1 (raw file):

Previously, lnhsingh (Lauren Hirata Singh) wrote…

This code block renders weird because it's in the callout. Though not ideal, maybe you can preface the note and code block with a "Note:" or "It should be noted that the Hibernate..."

Removed the note callout.


v20.2/build-a-spring-app-with-cockroachdb-jpa.md, line 86 at r1 (raw file):

Previously, lnhsingh (Lauren Hirata Singh) wrote…

Same as above

Done.

@ericharmeling ericharmeling merged commit 5fbd0d8 into master Aug 17, 2020
@ericharmeling ericharmeling deleted the spring-jpa-hibernate-dialect branch August 24, 2020 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CockroachDB Dialect/Adapter for Hibernate

3 participants