tool: print encoding during manifest dump with verbose flag

Adjust the pebble introspection tool for dumping a manifest file to include the
raw encoding of the version edit when the verbose flag is provided. This will
be helpful in cases such as cockroachlabs/support#3249.

Author: jbowens

tool/manifest.go

@@ -5,6 +5,7 @@
 package tool
 
 import (
+	"bytes"
 	"cmp"
 	"fmt"
 	"io"
@@ -14,6 +15,7 @@ import (
 	"github.com/HdrHistogram/hdrhistogram-go"
 	"github.com/cockroachdb/pebble"
 	"github.com/cockroachdb/pebble/internal/base"
+	"github.com/cockroachdb/pebble/internal/binfmt"
 	"github.com/cockroachdb/pebble/internal/humanize"
 	"github.com/cockroachdb/pebble/internal/manifest"
 	"github.com/cockroachdb/pebble/record"
@@ -161,6 +163,17 @@ func (m *manifestT) runDump(cmd *cobra.Command, args []string) {
 					fmt.Fprintf(stdout, "%s\n", err)
 					break
 				}
+				fmt.Fprintf(stdout, "%d/%d\n", offset, editIdx)
+				// If verbose, dump the binary encoding of the version edit.
+				if m.verbose {
+					data, err := io.ReadAll(r)
+					if err != nil {
+						fmt.Fprintf(stdout, "%s\n", err)
+						break
+					}
+					r = bytes.NewReader(data)
+					binfmt.FHexDump(stdout, data, 16, true)
+				}
 
 				var ve manifest.VersionEdit
 				err = ve.Decode(r)
@@ -178,7 +191,6 @@ func (m *manifestT) runDump(cmd *cobra.Command, args []string) {
 				}
 
 				empty := true
-				fmt.Fprintf(stdout, "%d/%d\n", offset, editIdx)
 				if ve.ComparerName != "" {
 					empty = false
 					fmt.Fprintf(stdout, "  comparer:     %s", ve.ComparerName)

tool/testdata/manifest_dump

@@ -45,6 +45,35 @@ EOF
 --- L5 ---
 --- L6 ---
 
+manifest dump --verbose
+../testdata/db-stage-4/MANIFEST-000006
+----
+MANIFEST-000006
+0/0
+00:  011a6c65 76656c64 622e4279 74657769 |  ..le veld b.By tewi
+10:  7365436f 6d706172 61746f72 02020307 |  seCo mpar ator ....
+20:  0400                                |  ..
+  comparer:     leveldb.BytewiseComparator
+  log-num:       2
+  next-file-num: 7
+41/1
+00:  02050306 040e6700 04c5050b 62617200 |  .... ..g. .... bar.
+10:  0e000000 0000000b 666f6f01 0d000000 |  .... .... foo. ....
+20:  0000000c 0e060585 a6b8ab06 01       |  .... .... .... .
+  log-num:       5
+  next-file-num: 6
+  last-seq-num:  14
+  added:         L0 000004:709<#12-#14>[bar#14,DEL-foo#13,SET] (2023-12-04T17:57:25Z)
+EOF
+--- L0.0 ---
+  000004:709<#12-#14>[bar#14,DEL-foo#13,SET]
+--- L1 ---
+--- L2 ---
+--- L3 ---
+--- L4 ---
+--- L5 ---
+--- L6 ---
+
 manifest dump --filter-start=zoo
 ../testdata/db-stage-4/MANIFEST-000006
 ----
@@ -53,6 +82,7 @@ MANIFEST-000006
   comparer:     leveldb.BytewiseComparator
   log-num:       2
   next-file-num: 7
+41/1
 EOF
 --- L0.0 ---
 --- L1 ---
@@ -70,6 +100,7 @@ MANIFEST-000006
   comparer:     leveldb.BytewiseComparator
   log-num:       2
   next-file-num: 7
+41/1
 EOF
 --- L0.0 ---
 --- L1 ---
@@ -321,6 +352,7 @@ MANIFEST-000001
 0/0
   comparer:     alt-comparer
   next-file-num: 2
+25/1
 38/1
   log-num:       4
   next-file-num: 6
@@ -335,6 +367,7 @@ MANIFEST-000001
   next-file-num: 7
   last-seq-num:  15
   added:         L0 000006:680<#15-#15>[bbb#15,SET-ccc#15,SET] (2023-12-12T18:55:00Z)
+193/4
 243/4
   next-file-num: 9
   last-seq-num:  16