@@ -96,7 +96,9 @@ func testGenerator(t *testing.T, reset func(), gen func() (string, bool)) {
9696 t .Run ("LogWriter" , func (t * testing.T ) {
9797 testGeneratorWriter (t , reset , gen , func (w io.Writer ) recordWriter {
9898 return NewLogWriter (w , 0 /* logNum */ , LogWriterConfig {
99- WALFsyncLatency : prometheus .NewHistogram (prometheus.HistogramOpts {})})
99+ WALFsyncLatency : prometheus .NewHistogram (prometheus.HistogramOpts {}),
100+ WriteWALSyncOffsets : func () bool { return false },
101+ })
100102 })
101103 })
102104}
@@ -640,7 +642,9 @@ func TestNoLastRecordOffset(t *testing.T) {
640642func TestInvalidLogNum (t * testing.T ) {
641643 var buf bytes.Buffer
642644 w := NewLogWriter (& buf , 1 , LogWriterConfig {
643- WALFsyncLatency : prometheus .NewHistogram (prometheus.HistogramOpts {})})
645+ WALFsyncLatency : prometheus .NewHistogram (prometheus.HistogramOpts {}),
646+ WriteWALSyncOffsets : func () bool { return false },
647+ })
644648 for i := 0 ; i < 10 ; i ++ {
645649 s := fmt .Sprintf ("%04d\n " , i )
646650 _ , err := w .WriteRecord ([]byte (s ))
@@ -735,7 +739,9 @@ func TestRecycleLog(t *testing.T) {
735739 }
736740
737741 w := NewLogWriter (limitedBuf , base .DiskFileNum (i ), LogWriterConfig {
738- WALFsyncLatency : prometheus .NewHistogram (prometheus.HistogramOpts {})})
742+ WALFsyncLatency : prometheus .NewHistogram (prometheus.HistogramOpts {}),
743+ WriteWALSyncOffsets : func () bool { return false },
744+ })
739745 sizes := make ([]int , 10 + rnd .IntN (100 ))
740746 for j := range sizes {
741747 data := randBlock ()
@@ -779,7 +785,9 @@ func TestRecycleLog(t *testing.T) {
779785func TestTruncatedLog (t * testing.T ) {
780786 backing := make ([]byte , 2 * blockSize )
781787 w := NewLogWriter (bytes .NewBuffer (backing [:0 ]), base .DiskFileNum (1 ), LogWriterConfig {
782- WALFsyncLatency : prometheus .NewHistogram (prometheus.HistogramOpts {})})
788+ WALFsyncLatency : prometheus .NewHistogram (prometheus.HistogramOpts {}),
789+ WriteWALSyncOffsets : func () bool { return false },
790+ })
783791 // Write a record that spans 2 blocks.
784792 _ , err := w .WriteRecord (bytes .Repeat ([]byte ("s" ), blockSize + 100 ))
785793 require .NoError (t , err )
@@ -795,15 +803,19 @@ func TestTruncatedLog(t *testing.T) {
795803func TestRecycleLogWithPartialBlock (t * testing.T ) {
796804 backing := make ([]byte , 27 )
797805 w := NewLogWriter (bytes .NewBuffer (backing [:0 ]), base .DiskFileNum (1 ), LogWriterConfig {
798- WALFsyncLatency : prometheus .NewHistogram (prometheus.HistogramOpts {})})
806+ WALFsyncLatency : prometheus .NewHistogram (prometheus.HistogramOpts {}),
807+ WriteWALSyncOffsets : func () bool { return false },
808+ })
799809 // Will write a chunk with 11 byte header + 5 byte payload.
800810 _ , err := w .WriteRecord ([]byte ("aaaaa" ))
801811 require .NoError (t , err )
802812 // Close will write a 11-byte EOF chunk.
803813 require .NoError (t , w .Close ())
804814
805815 w = NewLogWriter (bytes .NewBuffer (backing [:0 ]), base .DiskFileNum (2 ), LogWriterConfig {
806- WALFsyncLatency : prometheus .NewHistogram (prometheus.HistogramOpts {})})
816+ WALFsyncLatency : prometheus .NewHistogram (prometheus.HistogramOpts {}),
817+ WriteWALSyncOffsets : func () bool { return false },
818+ })
807819 // Will write a chunk with 11 byte header + 1 byte payload.
808820 _ , err = w .WriteRecord ([]byte ("a" ))
809821 require .NoError (t , err )
@@ -826,15 +838,19 @@ func TestRecycleLogNumberOverflow(t *testing.T) {
826838
827839 backing := make ([]byte , 27 )
828840 w := NewLogWriter (bytes .NewBuffer (backing [:0 ]), base .DiskFileNum (math .MaxUint32 ), LogWriterConfig {
829- WALFsyncLatency : prometheus .NewHistogram (prometheus.HistogramOpts {})})
841+ WALFsyncLatency : prometheus .NewHistogram (prometheus.HistogramOpts {}),
842+ WriteWALSyncOffsets : func () bool { return false },
843+ })
830844 // Will write a chunk with 11 byte header + 5 byte payload.
831845 _ , err := w .WriteRecord ([]byte ("aaaaa" ))
832846 require .NoError (t , err )
833847 // Close will write a 11-byte EOF chunk.
834848 require .NoError (t , w .Close ())
835849
836850 w = NewLogWriter (bytes .NewBuffer (backing [:0 ]), base .DiskFileNum (math .MaxUint32 + 1 ), LogWriterConfig {
837- WALFsyncLatency : prometheus .NewHistogram (prometheus.HistogramOpts {})})
851+ WALFsyncLatency : prometheus .NewHistogram (prometheus.HistogramOpts {}),
852+ WriteWALSyncOffsets : func () bool { return false },
853+ })
838854 // Will write a chunk with 11 byte header + 1 byte payload.
839855 _ , err = w .WriteRecord ([]byte ("a" ))
840856 require .NoError (t , err )
@@ -856,7 +872,9 @@ func TestRecycleLogWithPartialRecord(t *testing.T) {
856872 // Write a record that is larger than the log block size.
857873 backing1 := make ([]byte , 2 * blockSize )
858874 w := NewLogWriter (bytes .NewBuffer (backing1 [:0 ]), base .DiskFileNum (1 ), LogWriterConfig {
859- WALFsyncLatency : prometheus .NewHistogram (prometheus.HistogramOpts {})})
875+ WALFsyncLatency : prometheus .NewHistogram (prometheus.HistogramOpts {}),
876+ WriteWALSyncOffsets : func () bool { return false },
877+ })
860878 _ , err := w .WriteRecord (bytes .Repeat ([]byte ("a" ), recordSize ))
861879 require .NoError (t , err )
862880 require .NoError (t , w .Close ())
@@ -865,7 +883,9 @@ func TestRecycleLogWithPartialRecord(t *testing.T) {
865883 // the block size.
866884 backing2 := make ([]byte , 2 * blockSize )
867885 w = NewLogWriter (bytes .NewBuffer (backing2 [:0 ]), base .DiskFileNum (2 ), LogWriterConfig {
868- WALFsyncLatency : prometheus .NewHistogram (prometheus.HistogramOpts {})})
886+ WALFsyncLatency : prometheus .NewHistogram (prometheus.HistogramOpts {}),
887+ WriteWALSyncOffsets : func () bool { return false },
888+ })
869889 _ , err = w .WriteRecord (bytes .Repeat ([]byte ("b" ), recordSize ))
870890 require .NoError (t , err )
871891 require .NoError (t , w .Close ())
@@ -1083,7 +1103,9 @@ func BenchmarkRecordWrite(b *testing.B) {
10831103 for _ , size := range []int {8 , 16 , 32 , 64 , 256 , 1028 , 4096 , 65_536 } {
10841104 b .Run (fmt .Sprintf ("size=%d" , size ), func (b * testing.B ) {
10851105 w := NewLogWriter (io .Discard , 0 /* logNum */ , LogWriterConfig {
1086- WALFsyncLatency : prometheus .NewHistogram (prometheus.HistogramOpts {})})
1106+ WALFsyncLatency : prometheus .NewHistogram (prometheus.HistogramOpts {}),
1107+ WriteWALSyncOffsets : func () bool { return false },
1108+ })
10871109 defer w .Close ()
10881110 buf := make ([]byte , size )
10891111
0 commit comments