db: test that manual compactions aren't blocked by problem spans

Author: RaduBerinde

compaction_test.go

@@ -3021,6 +3021,17 @@ func TestCompactionCorruption(t *testing.T) {
 				return !hasExternalFiles(d)
 			})
 
+		case "manual-compaction":
+			if err := d.Compact([]byte("a"), []byte("z9999999"), true /* parallelize */); err != nil {
+				td.Fatalf(t, "manual compaction failed: %s", err)
+			}
+			v := d.DebugCurrentVersion()
+			for i := 0; i < numLevels-1; i++ {
+				if v.Levels[i].Len() > 0 {
+					td.Fatalf(t, "expected no tables on L%d", i)
+				}
+			}
+
 		default:
 			return fmt.Sprintf("unknown command: %s", td.Cmd)
 		}

testdata/compaction_corruption

@@ -16,7 +16,7 @@ y#0,SET = yvalue
 z#0,SET = zvalue
 ----
 
-ingest-external file1
+ingest-external
 file1 bounds=(a,c0)
 file2 bounds=(d,w0)
 file3 bounds=(x,z0)
@@ -46,3 +46,29 @@ expire-spans
 # files.
 wait-for-no-external-files
 ----
+
+build-remote file4-not-there
+a#0,SET = avalue
+u#0,SET = uvalue
+z#0,SET = zvalue
+----
+
+ingest-external
+file4 bounds=(a,z0)
+----
+
+# Verify that a problem span is set.
+wait-for-problem-span
+----
+
+stop-workload
+----
+
+# Make file4 appear.
+move-remote-object file4-not-there file4
+----
+file4-not-there -> file4
+
+# Verify that a manual compaction goes through despite the problem span.
+manual-compaction
+----