Refactor validation logic and add verbose logging support #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BramGruneir
requested changes
Sep 16, 2025
Collaborator
BramGruneir
left a comment
BramGruneir
left a comment
There was a problem hiding this comment.
Left a bunch of questions and comments.
internal/validate/validate.go
Outdated
| if fullCount != 1 { | ||
| return errors.Newf("expected exactly 1 full backup, got %d", fullCount) | ||
| if fullCount != expectedFullBackupCount { | ||
| return errors.Newf("expected exactly %d full backup, got %d", expectedFullBackupCount, fullCount) |
Collaborator
There was a problem hiding this comment.
nit: need to write backups if expectedFullBackupCount != 1
Collaborator
Author
There was a problem hiding this comment.
I don't understand your comment
internal/env/env.go
Outdated
| Endpoint string // the S3 endpoint | ||
| LookupEnv LookupEnv // allows injection of environment variable lookup for testing | ||
| Path string // the S3 bucket path | ||
| Short bool // Short validation, only guess params. |
Collaborator
There was a problem hiding this comment.
Does this actually do the work? It seems like it doesn't.
Collaborator
Author
There was a problem hiding this comment.
I changed to "guess", it tries different params combination and suggest one. It uses only the AWS SDK, without requiring access to the CRDB cluster. (If guess = false, then we run the full validation test)
sravotto
force-pushed
the
sr8_refact
branch
from
1223f51 to
74381f0
Compare
Collaborator
Author
|
Thanks, take another look please. |
BramGruneir
approved these changes
Sep 19, 2025
cmd/root.go
Outdated
| f.StringVar(&envConfig.Path, "path", envConfig.Path, "destination path (e.g. bucket/folder)") | ||
| f.StringVar(&envConfig.Endpoint, "endpoint", envConfig.Path, "http endpoint") | ||
| f.StringVar(&envConfig.URI, "uri", envConfig.URI, "S3 URI") | ||
| f.BoolVar(&envConfig.Guess, "guess", false, "perform a short test to guess suggested parameters") |
Collaborator
There was a problem hiding this comment.
please add a little bit to the description that says it does not run any other tests.
- Extract validate.go methods into smaller focused functions - Add input parameter validation and improved error handling - Optimize goroutine management with dedicated worker methods - Add verbose flag support to CLI and environment configuration - Add --worker count and --workload-duration as CLI parameters - Add --short-test flag for abbreviated test runs - Improve test configuration with better error reporting
sravotto
force-pushed
the
sr8_refact
branch
from
74381f0 to
2be2662
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.