-
Notifications
You must be signed in to change notification settings - Fork 0
validate: add Validator for backup/restore compatibility checks #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Introduces a Validator component to verify backup/restore functionality against storage providers. It: - Creates source and restored databases/tables - Runs workloads to generate and mutate data - Executes full + incremental backups - Validates backup metadata (1 full, 1 incremental) - Restores into a new database and compares fingerprints - Cleans up resources after validation It also introduce a simple workload that adds rows into a kv style table.
BramGruneir
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
| // to asses minimum compatibility at the functional level. | ||
| // This does not imply that a storage provider passing the test is supported. | ||
| func (v *Validator) Validate(ctx *stopper.Context) (*Report, error) { | ||
| conn, err := v.pool.Acquire(ctx) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is quite rough, as you mentioned, but a good first step.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, I'll clean it up - hopefully we get some feedback from some testers.
|
Thank you. |
Introduces a Validator component to verify backup/restore functionality
against storage providers. It: