feat: added with_context to user-configured operations (source, funct… #1275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgeh0
reviewed
Nov 11, 2025
| @@ -80,7 +80,8 @@ impl PyFunctionExecutor { | |||
| .transpose()? | |||
| .as_ref(), | |||
| ) | |||
| .to_result_with_py_trace(py)?; | |||
| .to_result_with_py_trace(py) | |||
| .with_context(|| format!("while calling user-configured function"))?; | |||
Member
There was a problem hiding this comment.
Can we also attach the function name?
The same for error messages below.
…ion, target) to hydrate error propagation
Gohlub
force-pushed
the
feat/improved-err-propagation
branch
from
78d4016 to
5f6660a
Compare
Member
|
hi @Gohlub new release is out and we have made a section for you! |
Contributor
Author
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ion, target) to hydrate error propagation
Solves #1061.
I exercised my own judgement in deciding which operations would benefit from extra context. I noticed some to be internal calls whose escalation would not be useful to the API consumer. In any case, let me know if I should add/remove/update any of the context fields.