fix: Make additionalProperties configurable in JSON schemas
#1312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Srihari Thyagarajan <hari.leo03@gmail.com>
… simplify JSON schema handling in `LlmGenerationClient`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #364
Gemini doesn't support
additionalPropertiesin JSON schemas, so we were recursively stripping it out after generation. Not great.Added a
supports_additional_propertiesbool toToJsonSchemaOptionsinstead. Now we just don't include it in the first place for Gemini (both AI Studio and Vertex AI), while other providers (OpenAI, Ollama, Anthropic, Bedrock) still get it.Removed the whole
remove_additional_propertiesworkaround function fromgemini.rs. Cleaner this way.