Skip to content

Minor bug fix for SplitRecursively: split right before it's too large. #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 19, 2025
Merged

Minor bug fix for SplitRecursively: split right before it's too large. #165

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/ops/functions/split_recursively.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,14 +334,14 @@ impl<'t, 's: 't> RecursiveChunker<'s> {
return;
}
let mut start_pos = chunks[0].start;
for i in 1..chunks.len() - 1 {
let chunk = &chunks[i];
if chunk.end - start_pos > self.chunk_size {
for i in 0..chunks.len() - 1 {
let next_chunk = &chunks[i + 1];
if next_chunk.end - start_pos > self.chunk_size {
let chunk = &chunks[i];
self.add_output(RangeValue::new(start_pos, chunk.end), output);

// Find the new start position, allowing overlap within the threshold.
let mut new_start_idx = i + 1;
let next_chunk = &chunks[i + 1];
while new_start_idx > 0 {
let prev_pos = chunks[new_start_idx - 1].start;
if prev_pos <= start_pos
Expand Down