Skip to content

Minor improvement: also allow collect() taking constant. #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 26, 2025
Merged

Minor improvement: also allow collect() taking constant. #216

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions python/cocoindex/flow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,7 @@ def __init__(self, flow_builder_state: _FlowBuilderState,
self._flow_builder_state = flow_builder_state
self._engine_data_collector = data_collector

def collect(self, **kwargs: DataSlice | GeneratedField):
def collect(self, **kwargs):
"""
Collect data into the collector.
"""
Expand All @@ -269,7 +269,8 @@ def collect(self, **kwargs: DataSlice | GeneratedField):
else:
raise ValueError(f"Unexpected generated field: {v}")
else:
regular_kwargs.append((k, _data_slice_state(v).engine_data_slice))
regular_kwargs.append(
(k, self._flow_builder_state.get_data_slice(v)))

self._flow_builder_state.engine_flow_builder.collect(
self._engine_data_collector, regular_kwargs, auto_uuid_field)
Expand Down