feat, chore : 예약에 fetchForShopDetailPage API 생성 및 오타 수정 #123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
YR8002
commented
Mar 29, 2023
YR8002
commented
- 예약에 fetchForShopDetailPage 추가 : shopDetail에서 기존의 fetchShop API 요청 시, 리뷰 작성자를 불러오기 힘든 이슈가 있었습니다. shopId를 기준으로 리뷰와 리뷰 작성자를 함께 리턴하는 API를 작성했습니다.
- 리뷰(서비스)의 findByShopId 이름 변경 : 페이징 로직이 추가되어 findByShopIdWithPage으로 변경되었습니다.
API : findByShopId -> findByShopIdWithPage 컬럼 오타 : createAt -> createdAt
Collaborator
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.