Skip to content

Reinstate the markdown restrictions on comments #1013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 4, 2017
Merged

Reinstate the markdown restrictions on comments #1013

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/code_corps/model/comment.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ defmodule CodeCorps.Comment do
def changeset(struct, params \\ %{}) do
struct
|> cast(params, [:markdown])
|> validate_required([:markdown])
|> MarkdownRendererService.render_markdown_to_html(:markdown, :body)
end

Expand Down
8 changes: 8 additions & 0 deletions test/lib/code_corps_web/controllers/comment_controller_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,14 @@ defmodule CodeCorpsWeb.CommentControllerTest do
assert_received {:track, ^user_id, "Edited Comment", ^tracking_properties}
end

@tag :authenticated
test "does not update chosen resource and renders errors when data is invalid", %{conn: conn, current_user: current_user} do
comment = insert(:comment, user: current_user)
attrs = @invalid_attrs |> Map.merge(%{user: current_user})
json = conn |> request_update(comment, attrs) |> json_response(422)
assert json["errors"] != %{}
end

test "does not update resource and renders 401 when not authenticated", %{conn: conn} do
assert conn |> request_update(@valid_attrs) |> json_response(401)
end
Expand Down