Added tracking of "Connected to GitHub" event to segment #1089
+35
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshsmith
force-pushed
the
1038-analytics-track-connected-to-github
branch
from
b357973 to
94fdd7e
Compare
joshsmith
force-pushed
the
1038-analytics-track-connected-to-github
branch
from
94fdd7e to
76cacc6
Compare
joshsmith
approved these changes
Oct 18, 2017
Contributor
joshsmith
left a comment
joshsmith
left a comment
There was a problem hiding this comment.
Looks good. Also added some extra traits we weren't tracking.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Adds tracking of "Connected to GitHub" event with Segment.
Considering the existence of #927, I did not rely on our tracker "plug" to implement tracking here and instead made it explicit by calling the
track/3function from the controller.Progress on: #1038