Fix identifiers in views to not preload for belongs_to IDs #1119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
begedin
previously approved these changes
Oct 25, 2017
Contributor
begedin
left a comment
begedin
left a comment
There was a problem hiding this comment.
Looks good. Love the performance boost. Should be good to go once tests are fixed.
joshsmith
force-pushed
the
fix-identifiers-in-views
branch
from
ada1979 to
2da53d5
Compare
Contributor
Author
|
I love it, too, especially later in the summer. |
joshsmith
force-pushed
the
fix-identifiers-in-views
branch
from
2da53d5 to
4f23fc9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Fixes identifiers in views to not preload when all we need is the relationship ID displayed.