Refactor AnalyticsIdentify plug to use pattern matching #405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbatson5
approved these changes
Nov 1, 2016
web/plugs/analytics_identify.ex
Outdated
| end | ||
| def call(conn, _opts), do: conn |> identify | ||
|
|
||
| def identify(%{assigns: %{current_user: user}} = conn) do |
Contributor
Author
There was a problem hiding this comment.
@sbatson5 I guess there's no reason why it can't be. Can you adjust your review to needs changes then so I know to change it?
There was a problem hiding this comment.
Lol. I don't know how to do that, haha
Contributor
Author
There was a problem hiding this comment.
Add another review that's a needs changes.
sbatson5
previously requested changes
Nov 1, 2016
sbatson5
left a comment
sbatson5
left a comment
There was a problem hiding this comment.
Can we make the identify method private for both cases?
Contributor
Author
|
@sbatson5 ready for another review. |
joshsmith
force-pushed
the
refactor-analytics-identify-plug
branch
from
78a2b01 to
9ad4078
Compare
joshsmith
force-pushed
the
refactor-analytics-identify-plug
branch
from
9ad4078 to
4e13dd0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Changes
if/elsestyle to pattern matching.