Refactor Organization Membership Controller Test #425
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
begedin
previously requested changes
Nov 3, 2016
Contributor
begedin
left a comment
begedin
left a comment
There was a problem hiding this comment.
Just a minor change I suggest. Otherwise looks good.
|
|
||
| test "filters resources by membership id", %{conn: conn} do | ||
| [membership_1, membership_2] = insert_pair(:organization_membership) | ||
| insert(:organization_membership) |
Contributor
There was a problem hiding this comment.
Similarly to a comment in my other review, while this is good, it could be rewritten in one line as
[membership_1, membership_2 | _] = insert_list(3, :organization_membership)
joshsmith
approved these changes
Nov 3, 2016
Contributor
|
Just rebase and squash! |
mackenziehicks
force-pushed
the
419-refactor-organization-membership-controller-test
branch
from
470a03a to
6a6a356
Compare
mackenziehicks
deleted the
419-refactor-organization-membership-controller-test
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Refactored by adding helpers from api_case.ex to the Organization Membership Controller Test
References
Fixes #419
Progress on: #413