Refactor Category Controller Tests #429
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| conn |> put(path, payload) | ||
| end | ||
|
|
||
| test "lists all entries on index", %{conn: conn} do |
There was a problem hiding this comment.
looks like this is missing describe "index" do
| category = Repo.get_by(Category, @valid_attrs) | ||
| assert category | ||
| assert response["data"]["id"] == "#{category.id}" | ||
| assert conn |> request_update(@valid_attrs) |> json_response(200) |
There was a problem hiding this comment.
For the organization membership update test:
organization = insert(:organization)
membership = insert(:organization_membership, organization: organization, role: "pending")
insert(:organization_membership, organization: organization, member: current_user, role: "owner")
`assert conn |> request_update(membership, @valid_attrs) |> json_response(200)`
Should I change it to look more like this one? Looks like the request_update helper has a default_record.
Contributor
There was a problem hiding this comment.
I don't think so, because you do need someone who's an organization admin to approve, right?
joshsmith
approved these changes
Nov 3, 2016
amyschools
force-pushed
the
427-category-controller-test
branch
from
35bf7e0 to
de38021
Compare
Contributor
|
@amyschools that commit message is a little unclear. |
amyschools
force-pushed
the
427-category-controller-test
branch
from
de38021 to
e623364
Compare
amyschools
force-pushed
the
427-category-controller-test
branch
from
e623364 to
7c35183
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Add api_case.ex helper functions to Category controller tests.
References
Closes #427
Progress on: #413