Refactor role controller test by adding helpers #435
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mackenziehicks
changed the title
Contributor
|
The tests are failing here. I think maybe the pagination tests are non-deterministic. |
Contributor
|
@begedin this is the same thing we've seen before, right? |
Contributor
|
@joshsmith Yes, looks like it. I guess it isn't fixed yet. |
joshsmith
approved these changes
Nov 5, 2016
mackenziehicks
force-pushed
the
432-refactor-page-controller-tests
branch
from
cd786d7 to
045cc0a
Compare
|
Changes Unknown when pulling 045cc0a on 432-refactor-page-controller-tests into * on develop*. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Added helpers from api_case.ex to the tests for Role Controller.
References
Fixes #433
Progress on: #413