New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor role controller test by adding helpers #435

Merged
merged 1 commit into from Nov 7, 2016

Conversation

Projects
None yet
5 participants
@mackenziehicks
Contributor

mackenziehicks commented Nov 3, 2016

What's in this PR?

Added helpers from api_case.ex to the tests for Role Controller.

References

Fixes #433

Progress on: #413

@coveralls

This comment has been minimized.

coveralls commented Nov 3, 2016

Coverage Status

Coverage increased (+0.8%) to 94.507% when pulling 6a9fbf4 on 432-refactor-page-controller-tests into ef84323 on develop.

@mackenziehicks mackenziehicks self-assigned this Nov 3, 2016

@mackenziehicks mackenziehicks changed the title from Refactor page controller test by adding helpers to Refactor role controller test by adding helpers Nov 3, 2016

@joshsmith

This comment has been minimized.

Contributor

joshsmith commented Nov 4, 2016

The tests are failing here. I think maybe the pagination tests are non-deterministic.

@joshsmith

This comment has been minimized.

Contributor

joshsmith commented Nov 4, 2016

@begedin this is the same thing we've seen before, right?

@coveralls

This comment has been minimized.

coveralls commented Nov 4, 2016

Coverage Status

Coverage increased (+1.1%) to 94.83% when pulling cd786d7 on 432-refactor-page-controller-tests into ef84323 on develop.

@begedin

This comment has been minimized.

Contributor

begedin commented Nov 4, 2016

@joshsmith Yes, looks like it. I guess it isn't fixed yet.

@sbatson5

LGTM 👍 👏

@mackenziehicks mackenziehicks force-pushed the 432-refactor-page-controller-tests branch from cd786d7 to 045cc0a Nov 7, 2016

@coveralls

This comment has been minimized.

coveralls commented Nov 7, 2016

Coverage Status

Changes Unknown when pulling 045cc0a on 432-refactor-page-controller-tests into * on develop*.

@mackenziehicks mackenziehicks merged commit 49f45b5 into develop Nov 7, 2016

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
coverage/coveralls First build on 432-refactor-page-controller-tests at 93.851%
Details

@mackenziehicks mackenziehicks deleted the 432-refactor-page-controller-tests branch Nov 7, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment