-
Notifications
You must be signed in to change notification settings - Fork 86
Reset password route #753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reset password route #753
Conversation
|
Wondering if we can just look up the token or should look up the token/user in the AuthToken model. |
|
This is looking pretty good. Where did tests go down? |
begedin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, @snewcomer
There is no need to change the property name in the model itself. My suggestion was just about having the public API interface be clear to the outside client. The model is internal to the API and should be clearer to the dev, so auth_token.value will make more sense that way. This is good to go.
|
@joshsmith Looks like tests going down is coveralls being coveralls. It reports them going down in files untouched by this PR. @snewcomer You'll have to rebase and rerun migrations to deal with the |
659452e to
2e99fcf
Compare
2e99fcf to
37217d2
Compare
|
Going to squash and merge! |
|
🎉 yay! |
What's in this PR?
password reset controller finding AuthToken.
@begedin should I also change the AuthToken model
valuetotoken?References
Fixes #731
Progress on: #498