Add sign up context #776
Merged
Add sign up context #776
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
begedin
previously requested changes
Mar 27, 2017
| def next("selected_roles", "select_skills"), do: {:ok, "selected_skills"} | ||
| def next("selected_roles", "skip_skills"), do: {:ok, "selected_skills"} | ||
| def next("skipped_roles", "select_skills"), do: {:ok, "selected_skills"} | ||
| def next("skipped_roles", "skip_skills"), do: {:ok, "selected_skills"} |
Contributor
There was a problem hiding this comment.
I wrote tests that are failing here, due to expecting a "skip_skills" transition to return a "skipped_skills". Basically, I assumed this was an oversight.
If I was mistaken and we really want the same final state in all 4 cases here, that state should, in my opinion, something not-misleading, such as "onboarded".
begedin
approved these changes
Mar 27, 2017
Add user_state_test
joshsmith
force-pushed
the
add-sign-up-context
branch
from
2a73a7e to
adea6cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
This adds a
sign_up_contexttoUserthat allows us to track how a user signed up.Also adds skippable state transitions.