File tree Expand file tree Collapse file tree 2 files changed +6
-5
lines changed Expand file tree Collapse file tree 2 files changed +6
-5
lines changed Original file line number Diff line number Diff line change @@ -5,7 +5,6 @@ import PageObject from 'ember-cli-page-object';
55import Ember from 'ember' ;
66import userSidebarComponent from '../../pages/components/user-sidebar' ;
77
8-
98const { set } = Ember ;
109
1110let page = PageObject . create ( userSidebarComponent ) ;
@@ -64,9 +63,9 @@ test('it renders all required elements', function(assert) {
6463 assert . equal ( page . name , 'Josh Smith' , 'Their name renders' ) ;
6564 assert . equal ( page . username , 'JoshSmith' , 'Their username renders' ) ;
6665 assert . equal ( page . twitterHandle , '@joshsmith' , 'Their twitter handler renders' ) ;
67- assert . equal ( this . $ ( 'li.twitter a' ) . attr ( 'href' ) , 'https://twitter.com/joshsmith' , 'The twitter link renders' ) ;
66+ assert . equal ( page . twitterLink , 'https://twitter.com/joshsmith' , 'The twitter link renders' ) ;
6867 assert . equal ( page . website , 'https://codecorps.org' , 'Their website renders' ) ;
69- assert . equal ( this . $ ( 'li.website a' ) . attr ( 'href' ) , 'https://codecorps.org' , 'The website link renders' ) ;
68+ assert . equal ( page . websiteLink , 'https://codecorps.org' , 'The website link renders' ) ;
7069} ) ;
7170
7271test ( 'it does not show some details if blank' , function ( assert ) {
Original file line number Diff line number Diff line change 1- import { isVisible , text , isHidden } from 'ember-cli-page-object' ;
1+ import { isVisible , text , isHidden , property } from 'ember-cli-page-object' ;
22
33export default {
44 scope : '.user-sidebar' ,
@@ -9,5 +9,7 @@ export default {
99 twitterHandle : text ( 'li.twitter' ) ,
1010 website : text ( 'li.website' ) ,
1111 twitterHandleHidden : isHidden ( 'li.twitter' ) ,
12- websiteHidden : isHidden ( 'li.website' )
12+ websiteHidden : isHidden ( 'li.website' ) ,
13+ twitterLink : property ( 'href' , 'li.twitter a' ) ,
14+ websiteLink : property ( 'href' , 'li.website a' )
1315} ;
You can’t perform that action at this time.
0 commit comments