feat: adds lesson_24 homework and lesson_25 pre-work #750
Conversation
Signed-off-by: Anthony D. Mays <anthony@morganlatimer.com>
There was a problem hiding this comment.
Pull Request Overview
This PR adds lesson 24 homework assignment and lesson 25 pre-work materials, introducing a full-stack React application with API integration and database preparation content.
- Adds complete lesson 24 homework with React template, API server, and shared types package
- Creates lesson 25 pre-work documentation with SQL learning resources
- Provides scaffolding for a full-stack web application using React, Express, and TypeScript
Reviewed Changes
Copilot reviewed 49 out of 57 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| lesson_25/README.md | Pre-work documentation with SQL learning resources |
| lesson_24/README.md | Updated homework assignment with API integration tasks |
| lesson_24/types/* | Shared TypeScript types package for Program interface |
| lesson_24/template/* | Complete React application template with components and styling |
| lesson_24/api/* | Express API server with CRUD operations and JSON file database |
Files not reviewed (1)
- lesson_24/types/package-lock.json: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| .program { | ||
| display: flex; | ||
| flex-direction: column; | ||
| max-width: 48%; | ||
| } | ||
|
|
||
| @media screen and (max-width: 1080px) { | ||
| .program { | ||
| min-width: 100%; | ||
| } | ||
| } No newline at end of file |
There was a problem hiding this comment.
This CSS file appears to be duplicated with the same content as Program.scss. The styles should be consolidated into a single location to avoid code duplication.
| .program { | |
| display: flex; | |
| flex-direction: column; | |
| max-width: 48%; | |
| } | |
| @media screen and (max-width: 1080px) { | |
| .program { | |
| min-width: 100%; | |
| } | |
| } | |
| @import '../Program/Program.scss'; |
| @@ -0,0 +1,30 @@ | |||
| import App from './App.tsx'; | |||
| import {Home} from './pages/Home/Home.tsx'; | |||
There was a problem hiding this comment.
The import should use the index.ts barrel export from './pages/Home' instead of directly importing from 'Home.tsx' to maintain consistency with the established pattern.
| import {Home} from './pages/Home/Home.tsx'; | |
| import {Home} from './pages/Home'; |
| "nodemon": "^3.1.7", | ||
| "prettier": "^3.4.1", | ||
| "supertest": "^7.0.0", | ||
| "ts-jest": "^29.2.5", | ||
| "@types/node": "^22.10.2", | ||
| "nodemon": "^3.1.9", | ||
| "prettier": "3.4.2", |
There was a problem hiding this comment.
Duplicate dependencies detected: 'nodemon' appears on lines 23 and 28, and 'prettier' appears on lines 24 and 29 with different versions. These duplicates should be removed.
| "nodemon": "^3.1.7", | |
| "prettier": "^3.4.1", | |
| "supertest": "^7.0.0", | |
| "ts-jest": "^29.2.5", | |
| "@types/node": "^22.10.2", | |
| "nodemon": "^3.1.9", | |
| "prettier": "3.4.2", | |
| "nodemon": "^3.1.9", | |
| "prettier": "3.4.2", | |
| "supertest": "^7.0.0", | |
| "ts-jest": "^29.2.5", | |
| "@types/node": "^22.10.2", |
Signed-off-by: Anthony D. Mays anthony@morganlatimer.com