improve script

Author: molly-moen

load-test/Dockerfile

@@ -1,5 +1,5 @@
 FROM loadimpact/k6
-ENV SCRIPT hello-world-load-test.js
+ENV SCRIPT loadTest.js
 COPY ./scripts /scripts
 WORKDIR /scripts
 # Override the entry point of the base k6 image

load-test/scripts/configuration.js

@@ -1,33 +1,3 @@
-export const BASIC_TEST_OPTIONS = {
-  scenarios: {
-    // ramp up to 5 VUs over 30 seconds
-    rampUp: {
-      executor: "ramping-vus",
-      startVUs: 0,
-      stages: [
-        {duration: '30s', target: 5}
-      ]
-    },
-    // have 5 VUs do 3 iterations each, up to a max of 2 minutes. Start this after
-    // the ramp up time.
-    highLoad: {
-      executor: "per-vu-iterations",
-      vus: 5,
-      iterations: 3,
-      maxDuration: "2m",
-      startTime: '30s',
-    }
-  },
-  thresholds: {
-    exceptions: ["count == 0"],
-    errors: ["count == 0"],
-    websocket_session_duration_without_sleep: ["p(95) < 5000"],
-    long_websocket_sessions: ["count <= 1"],
-    extra_long_websocket_sessions: ["count == 0"]
-  },
-  summaryTrendStats: ["avg", "min", "med", "max", "p(90)", "p(95)", "p(98)", "p(99)"],
-};
-
 // TODO: Update to a load testing instance of Javabuilder
 export const UPLOAD_URL = `https://javabuilder-molly-http.dev-code.org/seedsources/sources.json?Authorization=`;
 export const WEBSOCKET_URL = `wss://javabuilder-molly.dev-code.org?Authorization=`;
@@ -50,12 +20,48 @@ export const UPLOAD_PARAMS = {
 export const PRIVATE_KEY = null;
 
 // Thresholds for metrics
+// Long requests time: we don't want requests to go over this time in the p(95) case
 export const LONG_REQUEST_MS = 5000;
-export const EXTRA_LONG_REQUEST_MS = 10000;
+// Extra long request time: we never want requests to go over this time.
+export const EXTRA_LONG_REQUEST_MS = 14000;
 
 // Mini-app types
 export const MiniAppType = {
   CONSOLE: 'console',
   NEIGHBORHOOD: 'neighborhood',
   THEATER: 'theater'
 };
+
+export function getTestOptions(maxUserGoal, rampUpTimeMinutes, highLoadTimeMinutes) {
+  const maxConcurrentUsers =  Math.floor(maxUserGoal / 30);
+  return  {
+    scenarios: {
+      // ramp up to maxConcurrentUsers VUs over rampUpTimeMinutes
+      rampUp: {
+        executor: "ramping-vus",
+        startVUs: 0,
+        stages: [
+          {duration: `${rampUpTimeMinutes}m`, target: maxConcurrentUsers}
+        ]
+      },
+      // have maxConcurrentUsers VUs do 3 iterations each minute, for a total of highLoadTimeMinutes * 3
+      // iterations per virutal user.
+      // Start this after the ramp up time and allow for 1 extra minute in the max duration in case of issues.
+      highLoad: {
+        executor: "per-vu-iterations",
+        vus: maxConcurrentUsers,
+        iterations: 3 * highLoadTimeMinutes, // this is iterations per virtual user
+        maxDuration: `${highLoadTimeMinutes + 1}m`,
+        startTime: `${rampUpTimeMinutes}m`,
+      }
+    },
+    thresholds: {
+      exceptions: ["count == 0"],
+      errors: ["count == 0"],
+      websocket_session_duration_without_sleep: ["p(95) < 5000"],
+      long_websocket_sessions: [`count <= ${maxConcurrentUsers}`],
+      extra_long_websocket_sessions: ["count == 0"]
+    },
+    summaryTrendStats: ["avg", "min", "med", "max", "p(90)", "p(95)", "p(98)", "p(99)"],
+  };
+}

…ad-test/scripts/hello-world-load-test.js load-test/scripts/loadTest.jsload-test/scripts/hello-world-load-test.js renamed to load-test/scripts/loadTest.js load-test/scripts/hello-world-load-test.js renamed to load-test/scripts/loadTest.js

@@ -6,33 +6,41 @@ import { helloWorld } from "./sources.js";
 import {
   LONG_REQUEST_MS,
   EXTRA_LONG_REQUEST_MS,
-  BASIC_TEST_OPTIONS,
   MiniAppType,
   UPLOAD_URL,
   UPLOAD_PARAMS,
   WEBSOCKET_URL,
-  WEBSOCKET_PARAMS
+  WEBSOCKET_PARAMS,
+  getTestOptions
 } from "./configuration.js";
 import generateToken from "./generateToken.js";
 
-export const options = BASIC_TEST_OPTIONS;
+// Change these options to increase the user goal or time to run the test.
+export const options = getTestOptions(
+  /* User goal */ 150,
+  /* Ramp up time minutes */ 1,
+  /* High load time minutes */ 5
+);
+
+// Change this to test different code
+const sourceToTest = helloWorld;
 
 const exceptionCounter = new Counter("exceptions");
 const errorCounter = new Counter("errors");
 const connectToCloseTime = new Trend(
   "websocket_session_duration_without_sleep",
   true
 );
-// websocket sessions > 5 seconds
+// websocket sessions > LONG_REQUEST_MS
 const longWebsocketSessions = new Counter("long_websocket_sessions");
-// websocket sessions > 10 seconds
+// websocket sessions > EXTRA_LONG_REQUEST_MS
 const extraLongWebsocketSessions = new Counter("extra_long_websocket_sessions");
 
 export default function () {
   const authToken = generateToken(MiniAppType.CONSOLE);
   const uploadResult = http.put(
     UPLOAD_URL + authToken,
-    helloWorld,
+    sourceToTest,
     UPLOAD_PARAMS
   );
   const res = ws.connect(WEBSOCKET_URL + authToken, WEBSOCKET_PARAMS, (socket) =>
@@ -50,7 +58,6 @@ function onSocketConnect(socket, startTime) {
   socket.on("message", function (data) {
     const parsedData = JSON.parse(data);
     if (parsedData.type === "EXCEPTION") {
-      console.log("hit an exception " + parsedData.value);
       exceptionCounter.add(1);
     }
   });
@@ -68,7 +75,6 @@ function onSocketConnect(socket, startTime) {
   });
 
   socket.on("error", function (e) {
-    console.log("error occurred: " + e.error());
     errorCounter.add(1);
   });
 }