Skip to content

Commit e8b49d0

Browse files
committed
address comments
1 parent 994a887 commit e8b49d0

File tree

1 file changed

+7
-14
lines changed

1 file changed

+7
-14
lines changed

load-test/scripts/loadTest.js

Lines changed: 7 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ export const options = getTestOptions(
2222
);
2323

2424
// Change this to test different code
25-
const sourceToTest = helloWorld;
25+
const SOURCE_TO_TEST = helloWorld;
2626
// Set this to true to space out requests every REQUEST_TIME_MS milliseconds. Set to
2727
// false to send as many requests as possible.
2828
const SHOULD_SLEEP = false;
@@ -34,9 +34,10 @@ const totalSessionTime = new Trend("total_session_time", true);
3434
const sessionsOver10Seconds = new Counter("session_over_10_seconds");
3535
const sessionsOver15Seconds = new Counter("session_over_15_seconds");
3636
const sessionsOver20Seconds = new Counter("session_over_20_seconds");
37-
const zeroRetries = new Counter("sessions_with_0_retries");
38-
const oneRetry = new Counter("sessions_with_1_retry");
39-
const twoRetries = new Counter("sessions_with_2_retries");
37+
const retryCounters = [new Counter("sessions_with_0_retries"), new Counter("sessions_with_1_retry"), new Counter("sessions_with_2_retries")];
38+
// const zeroRetries = new Counter("sessions_with_0_retries");
39+
// const oneRetry = new Counter("sessions_with_1_retry");
40+
// const twoRetries = new Counter("sessions_with_2_retries");
4041

4142

4243
function isResultSuccess(result) {
@@ -49,7 +50,7 @@ export default function () {
4950
const authToken = generateToken(MiniAppType.CONSOLE, sessionId);
5051
const uploadResult = http.put(
5152
UPLOAD_URL + authToken,
52-
sourceToTest,
53+
SOURCE_TO_TEST,
5354
UPLOAD_PARAMS
5455
);
5556

@@ -79,15 +80,7 @@ function connectToWebsocketWithRetry(authToken, sessionId, requestStartTime) {
7980
}
8081
tries++;
8182
}
82-
if (tries === 1) {
83-
zeroRetries.add(1);
84-
} else if (tries === 2) {
85-
oneRetry.add(1);
86-
} else if (tries === 3) {
87-
twoRetries.add(1);
88-
} else {
89-
console.log(`Unexpected number of retries: ${tries}`);
90-
}
83+
retryCounters[tries - 1].add(1);
9184
return res;
9285
}
9386

0 commit comments

Comments
 (0)