Ensure inner corners get a solid wall tile, not a randomized one #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I really like this solution. |
joshlory
commented
Jun 28, 2018
| // Draw the tile. | ||
| if (!TILE_SHAPES[tile]) { | ||
| const adjacentToPath = tile !== '00000'; | ||
| const innerCorner = adjacentToPath && tile.split('1').length > 2; |
Contributor
Author
There was a problem hiding this comment.
Add comment explaining what innerCorner means, since it can also be island blocks.
Codecov Report
@@ Coverage Diff @@
## master #15 +/- ##
=========================================
+ Coverage 40.37% 40.48% +0.1%
=========================================
Files 22 22
Lines 1372 1371 -1
Branches 223 223
=========================================
+ Hits 554 555 +1
+ Misses 684 682 -2
Partials 134 134
Continue to review full report at Codecov.
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Request from @kiki-lee. For young students, having a triangle block at these locations can be confusing.
This also removes the special casing for puzzles 1, 2 & 4 of the original HoC.