Adding second paint glomming algorithm and createDrawer flag to switch between SquareDrawer and CircleDrawer #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannahbergam
changed the title
| node.querySelectorAll("*").forEach((n) => n.remove()); | ||
| } | ||
| smallCornerSvg(top, grid, id, size, Corner.topLeft); | ||
| smallCornerSvg(top, grid, id, size, Corner.topRight); |
There was a problem hiding this comment.
I can't help but notice same values grid, id, and size. One possible further implementation we could do is define a helper function
smallCornerSvgHelper(color, position) {
return smallCornerSvg(color, grid, id, size, position)
}
Or something in that direction
There was a problem hiding this comment.
It'd have to be within this method though, which seems weird.
Contributor
Author
There was a problem hiding this comment.
Yes^^ this is a great point. I agree it's weird to have the repetition, but it feels better now that they're at least one liners. I can play around with it and see if there's a better way to handle the other variables.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.