-
Notifications
You must be signed in to change notification settings - Fork 63
Tjlivesey master #129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tjlivesey master #129
Conversation
…livesey-master
Also extract the url matching logic in its own class.
|
I tried pulling down master and building/installing the gem locally - though I was not very successful in adding things to my Procfile that contain a period in the service name. i.e. www.app.dev or www.app I'll wait for the gem update. |
|
I think thats because So, |
|
That is a shame but IMHO its best not to stray from the the procfile spec if its a format that will be supported. What if invoker used symlinks for HTTP services like POW, and then procfiles and INI's for everything else? I apologize if this has already been asked before. I cringe at making the suggestion, but I have a few reasons why I ask:
Again, I am sorry if this suggestion is offensive to the directions or decisions that have been made previously. I feel like POW is a bit more usable because of its ability to support subdomains with a simple symlink and I think if Invoker had the same paradigm it would be easier to adopt. Thoughts? |
|
Well, Pow can only manage http only programs whereas Invoker is a generic process supervisor which can manage pretty much anything. I am not keen on supporting symlink feature for Invoker. I spoke with Foreman author though and apparently not allowing |
|
Even better 👍 |
This implements #116 building on top of work done in #117
The net result is:
EDIT: Actually since
.is not allowed in Procfile labels, above will not work with Procfiles.or in ini Format:
And the
chat.app.devwill point to chat app andapp.devwill point to Rails app as expected. Any other subdomains overapp.devwill still go to the Rails app and hencefoo.app.devwill go to Rails app.