Conversation
EVENT_FORMAT.md
Outdated
Member
There was a problem hiding this comment.
any reason why response is not sent over PUB socket?
Contributor
Author
There was a problem hiding this comment.
Since this is a handshake, I am thinking the client will wait for the server to respond synchronously. The client should ideally not proceed to do other things unless the handshake goes through fine and gives it enough info about the server's status. This info can be used going forward to set the client state as well, for example enable/disable buttons.
Conflicts: docs/EVENT_FORMAT.md
Contributor
|
@emilsoman do you want to have a look why this is failing on Ruby 2.2.0 ? |
gnufied
pushed a commit
that referenced
this pull request
Jan 2, 2015
Handshake response which sends basic info to the client
Contributor
|
Well the failures seems to be unrelated, so I am going to merge this. We will have to separately look into these spit-brain spec failures. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #84