Skip to content

Conversation

@BioPhoton
Copy link
Collaborator

@BioPhoton BioPhoton commented Sep 2, 2025

This PR includes:

  • refactor the task graph of the code-pushup-coverage target
Screenshot 2025-09-02 at 14 16 35

Note

This change is needed to be able to reuse the test work across critical checks and conformance.
The dependsOn setting also enables a graceful handling of cases where a projects has not all of the listed test targets.

@nx-cloud
Copy link

nx-cloud bot commented Sep 2, 2025

View your CI Pipeline Execution ↗ for commit 85ec45f

Command Status Duration Result
nx code-pushup --nx-bail -- compare --verbose ✅ Succeeded 1m 36s View ↗
nx code-pushup --nx-bail -- --verbose ✅ Succeeded 1m 45s View ↗
nx code-pushup --nx-bail -- print-config --verb... ✅ Succeeded 10m 14s View ↗

☁️ Nx Cloud last updated this comment at 2025-09-02 12:39:47 UTC

@pkg-pr-new
Copy link

pkg-pr-new bot commented Sep 2, 2025

Open in StackBlitz

@code-pushup/ci

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/ci@1098

@code-pushup/cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/cli@1098

@code-pushup/create-cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/create-cli@1098

@code-pushup/core

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/core@1098

@code-pushup/models

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/models@1098

@code-pushup/nx-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/nx-plugin@1098

@code-pushup/coverage-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/coverage-plugin@1098

@code-pushup/eslint-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/eslint-plugin@1098

@code-pushup/js-packages-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/js-packages-plugin@1098

@code-pushup/jsdocs-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/jsdocs-plugin@1098

@code-pushup/lighthouse-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/lighthouse-plugin@1098

@code-pushup/typescript-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/typescript-plugin@1098

@code-pushup/utils

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/utils@1098

@code-pushup/models-transformers

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/models-transformers@1098

commit: 85ec45f

@BioPhoton BioPhoton marked this pull request as ready for review September 2, 2025 12:22
@BioPhoton BioPhoton requested a review from matejchalk September 2, 2025 12:23
@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2025

Code PushUp

😟 Code PushUp report has regressed – compared current commit 04c404f with previous commit 4367e53.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Performance 🔴 33 🔴 32 ↓ −1.6
Code coverage 🟢 90 🟢 90 ↓ −0.1
Security 🟡 64 🟡 64
Updates 🟡 85 🟡 85
Accessibility 🟢 92 🟢 92
Best Practices 🟢 100 🟢 100
SEO 🟡 61 🟡 61
Type Safety 🟢 100 🟢 100
Bug prevention 🟢 100 🟢 100
Miscellaneous 🟢 100 🟢 100
Code style 🟢 100 🟢 100
Documentation 🔴 23 🔴 23
👎 2 groups regressed, 👎 5 audits regressed, 15 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Lighthouse Performance 🔴 33 🔴 32 ↓ −1.6
Code coverage Code coverage metrics 🟢 90 🟢 90 ↓ −0.1

19 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse Speed Index 🟥 7.1 s 🟥 7.7 s ↑ +8.9 %
Lighthouse First Contentful Paint 🟥 3.2 s 🟥 3.3 s ↑ +3.7 %
Lighthouse Total Blocking Time 🟥 2,960 ms 🟥 4,290 ms ↑ +45 %
Code coverage Line coverage 🟨 87.5 % 🟨 87.2 % ↓ −0.3 %
Code coverage Branch coverage 🟨 86.3 % 🟨 86.3 % ↓ −0.1 %
Lighthouse Avoids enormous network payloads 🟨 Total size was 2,687 KiB 🟨 Total size was 2,718 KiB ↑ +1.2 %
Lighthouse Minimizes main-thread work 🟥 13.3 s 🟥 15.0 s ↑ +13.1 %
Lighthouse JavaScript execution time 🟥 5.5 s 🟥 6.9 s ↑ +26.5 %
Lighthouse Largest Contentful Paint 🟥 11.4 s 🟥 12.2 s ↑ +7.2 %
Lighthouse Uses efficient cache policy on static assets 🟨 32 resources found 🟨 32 resources found ↑ +0.1 %
Lighthouse Time to Interactive 🟥 17.4 s 🟥 17.8 s ↑ +1.8 %
Lighthouse Metrics 🟩 100% 🟩 100% ↑ +1.8 %
Lighthouse Max Potential First Input Delay 🟥 1,310 ms 🟥 1,590 ms ↑ +21.4 %
Lighthouse Reduce unused CSS 🟥 Potential savings of 113 KiB 🟥 Potential savings of 113 KiB ↓ −23.3 %
Lighthouse Remove duplicate modules in JavaScript bundles 🟥 Potential savings of 101 KiB 🟥 Potential savings of 94 KiB ↓ −31.1 %
Lighthouse Reduce unused JavaScript 🟥 Potential savings of 582 KiB 🟥 Potential savings of 582 KiB ↓ −14.4 %
Lighthouse Initial server response time was short 🟩 Root document took 500 ms 🟩 Root document took 390 ms ↓ −20.4 %
Lighthouse Server Backend Latencies 🟩 1,310 ms 🟩 1,340 ms ↑ +2.6 %
Lighthouse Network Round Trip Times 🟩 70 ms 🟩 60 ms ↓ −15.3 %
Lighthouse Cumulative Layout Shift 🟩 0.001 🟩 0 ↓ −100 %

590 other audits are unchanged.

@BioPhoton BioPhoton merged commit e76011b into main Sep 2, 2025
17 checks passed
@BioPhoton BioPhoton deleted the chore/adjust-cp-coverage-target branch September 2, 2025 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants