Skip to content

Conversation

@hanna-skryl
Copy link
Collaborator

@hanna-skryl hanna-skryl commented Nov 20, 2025

Use Node's module resolution and npm bin specification to locate and execute playwright-core CLI directly, instead of relying on npx, which fails with pnpm's strict dependency isolation.

With pnpm, transitive dependency binaries are not hoisted to the root node_modules/.bin directory, causing npx playwright-core to fail with playwright-core: command not found.

The fix was verified with all major package managers by installing the preview package https://pkg.pr.new/code-pushup/cli/@code-pushup/axe-plugin@1150 and testing browser installation with Axe accessibility audits:

  • pnpm (local + GitHub Actions CI)
  • npm (local)
  • yarn (local)

@hanna-skryl hanna-skryl self-assigned this Nov 20, 2025
@nx-cloud
Copy link

nx-cloud bot commented Nov 20, 2025

View your CI Pipeline Execution ↗ for commit 625e7f7

Command Status Duration Result
nx code-pushup --nx-bail -- compare ✅ Succeeded 55s View ↗
nx code-pushup --nx-bail -- ✅ Succeeded 1m 9s View ↗
nx code-pushup --nx-bail -- print-config --outp... ✅ Succeeded 4m 21s View ↗

☁️ Nx Cloud last updated this comment at 2025-11-20 15:37:38 UTC

@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 20, 2025

Open in StackBlitz

@code-pushup/ci

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/ci@1150

@code-pushup/cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/cli@1150

@code-pushup/core

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/core@1150

@code-pushup/create-cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/create-cli@1150

@code-pushup/models

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/models@1150

@code-pushup/nx-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/nx-plugin@1150

@code-pushup/axe-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/axe-plugin@1150

@code-pushup/coverage-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/coverage-plugin@1150

@code-pushup/eslint-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/eslint-plugin@1150

@code-pushup/js-packages-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/js-packages-plugin@1150

@code-pushup/jsdocs-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/jsdocs-plugin@1150

@code-pushup/lighthouse-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/lighthouse-plugin@1150

@code-pushup/typescript-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/typescript-plugin@1150

@code-pushup/utils

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/utils@1150

@code-pushup/models-transformers

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/models-transformers@1150

commit: 625e7f7

@github-actions
Copy link
Contributor

github-actions bot commented Nov 20, 2025

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit c266afa with previous commit e901640.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
SEO 🟡 61 🟢 92 ↑ +31
Performance 🔴 34 🔴 33 ↓ −0.3
Documentation 🔴 35 🔴 35 ↑ +0.1
Code coverage 🟡 89 🟡 89 ↓ −0.1
Security 🔴 43 🔴 43
Updates 🟡 71 🟡 71
Accessibility 🟢 92 🟢 92
Best Practices 🟢 100 🟢 100
Type Safety 🟢 100 🟢 100
Bug prevention 🟢 100 🟢 100
Miscellaneous 🟢 100 🟢 100
Code style 🟢 100 🟢 100
👍 2 groups improved, 👎 2 groups regressed, 👍 3 audits improved, 👎 4 audits regressed, 14 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Lighthouse SEO 🟡 61 🟢 92 ↑ +31
Lighthouse Performance 🔴 34 🔴 33 ↓ −0.3
JSDoc coverage Documentation coverage 🔴 35 🔴 35 ↑ +0.1
Code coverage Code coverage metrics 🟡 89 🟡 89 ↓ −0.1

19 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse Page isn’t blocked from indexing 🟥 failed 🟩 passed ↑ +∞ %
Lighthouse Speed Index 🟥 7.0 s 🟥 6.7 s ↓ −4.4 %
Lighthouse Time to Interactive 🟥 13.7 s 🟥 14.5 s ↑ +6.2 %
Lighthouse Total Blocking Time 🟥 2,510 ms 🟥 3,190 ms ↑ +27.2 %
Lighthouse First Contentful Paint 🟥 3.3 s 🟥 3.3 s ↑ +1 %
JSDoc coverage Functions coverage 🟥 555 undocumented functions 🟥 554 undocumented functions ↓ −0.2 %
Code coverage Line coverage 🟨 85.2 % 🟨 85.2 % ↓ −0.1 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 2,019 KiB 🟩 Total size was 2,012 KiB ↓ −0.3 %
Lighthouse Minimizes main-thread work 🟥 13.7 s 🟥 16.5 s ↑ +20.8 %
Lighthouse JavaScript execution time 🟥 5.2 s 🟥 6.9 s ↑ +32.7 %
Lighthouse Server Backend Latencies 🟩 1,520 ms 🟩 530 ms ↓ −65.2 %
Lighthouse Largest Contentful Paint 🟥 11.4 s 🟥 12.4 s ↑ +8.5 %
Lighthouse Metrics 🟩 100% 🟩 100% ↑ +6.2 %
Lighthouse Max Potential First Input Delay 🟥 1,160 ms 🟥 1,980 ms ↑ +71.4 %
Lighthouse Uses efficient cache policy on static assets 🟨 30 resources found 🟨 30 resources found ↑ +0.1 %
Lighthouse Reduce unused CSS 🟥 Potential savings of 105 KiB 🟥 Potential savings of 104 KiB ↓ −25.4 %
Lighthouse Reduce unused JavaScript 🟥 Potential savings of 184 KiB 🟥 Potential savings of 184 KiB ↓ −17 %
Lighthouse Remove duplicate modules in JavaScript bundles 🟥 Potential savings of 105 KiB 🟥 Potential savings of 104 KiB ↑ +51.6 %
Lighthouse Initial server response time was short 🟩 Root document took 410 ms 🟩 Root document took 560 ms ↑ +35.7 %
Lighthouse Network Round Trip Times 🟩 50 ms 🟩 30 ms ↓ −47.6 %
Code coverage Branch coverage 🟨 87 % 🟨 87.1 % ↑ +0.1 %

657 other audits are unchanged.

@hanna-skryl hanna-skryl marked this pull request as ready for review November 20, 2025 02:00
@hanna-skryl hanna-skryl added 🐛 bug something isn't working 🧩 axe-plugin labels Nov 20, 2025
@hanna-skryl hanna-skryl merged commit d900344 into main Nov 20, 2025
21 checks passed
@hanna-skryl hanna-skryl deleted the pnpm-browser-installation branch November 20, 2025 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🧩 axe-plugin 🐛 bug something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants