Skip to content

Conversation

@matejchalk
Copy link
Collaborator

@matejchalk matejchalk commented Aug 28, 2023

Created a GitHub Action which checks our code on every push.

Checks include:

  • dependency audit (only vulnerabilities in production dependencies will cause an error)
  • Prettier formatting must be applied
  • ESLint must pass without warnings or errors
  • tests must pass
    • unit tests under test target
    • E2E tests under e2e target
  • build must succeed

Checks only run for affected projects. The nrwl/nx-set-shas GitHub Action takes care of determining the correct base and head.

Closes #7

Copy link

@ChristopherPHolder ChristopherPHolder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great ready to be merged

@matejchalk matejchalk merged commit c3f695f into main Aug 29, 2023
@matejchalk matejchalk deleted the ci-setup branch August 29, 2023 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI setup for open-source repo

3 participants