build: update Nx 19 & other dependencies

.eslintrc.json

@@ -1,6 +1,6 @@
 {
   "root": true,
-  "ignorePatterns": ["**/*"],
+  "ignorePatterns": ["**/*", "*.config*"],
   "plugins": ["@nx"],
   "overrides": [
     {
@@ -91,14 +91,21 @@
       "rules": {
         "vitest/consistent-test-filename": [
           "warn",
-          { "pattern": ".*\\.(unit|integration|e2e)\\.test\\.[tj]sx?$" }
-        ]
+          {
+            "pattern": ".*\\.(unit|integration|e2e)\\.test\\.[tj]sx?$"
+          }
+        ],
+        "@typescript-eslint/no-extra-semi": "error",
+        "no-extra-semi": "off"
       }
     },
     {
       "files": ["*.js", "*.jsx"],
       "extends": ["plugin:@nx/javascript", "@code-pushup"],
-      "rules": {}
+      "rules": {
+        "@typescript-eslint/no-extra-semi": "error",
+        "no-extra-semi": "off"
+      }
     },
     {
       "files": "*.json",

.github/labeler.yml

@@ -73,7 +73,6 @@
           - 'nx.json'
           - '.nvmrc'
           - '.prettierrc'
-          - 'esbuild.config.js'
           - '.github/ISSUE_TEMPLATE/**'
           - '.husky/**'
           - 'commitlint.config.mjs'

.gitignore

@@ -47,4 +47,4 @@ Thumbs.db
 **/.code-pushup
 
 # Nx workspace cache
-.nx/cache
+.nx

.prettierignore

@@ -1,5 +1,5 @@
 # Add files here to ignore them from prettier formatting
 /dist
 /coverage
-/.nx/cache
+/.nx
 __snapshots__

code-pushup.config.ts

@@ -5,16 +5,9 @@ import {
   eslintCoreConfigNx,
   jsPackagesCoreConfig,
   lighthouseCoreConfig,
-} from './code-pushup.preset';
-import {
-  fileSizePlugin,
-  fileSizeRecommendedRefs,
-  packageJsonDocumentationGroupRef,
-  packageJsonPerformanceGroupRef,
-  packageJsonPlugin,
-} from './dist/examples/plugins';
-import { mergeConfigs } from './dist/packages/utils';
-import type { CoreConfig } from './packages/models/src';
+} from './code-pushup.preset.js';
+import type { CoreConfig } from './packages/models/src/index.js';
+import { mergeConfigs } from './packages/utils/src/index.js';
 
 // load upload configuration from environment
 const envSchema = z.object({
@@ -35,31 +28,7 @@ const config: CoreConfig = {
     },
   }),
 
-  plugins: [
-    fileSizePlugin({
-      directory: './dist/packages',
-      pattern: /\.js$/,
-      budget: 174_080, // 170 kB
-    }),
-
-    packageJsonPlugin({
-      directory: './dist/packages',
-      license: 'MIT',
-      type: 'module',
-    }),
-  ],
-
-  categories: [
-    {
-      slug: 'custom-checks',
-      title: 'Custom checks',
-      refs: [
-        ...fileSizeRecommendedRefs,
-        packageJsonPerformanceGroupRef,
-        packageJsonDocumentationGroupRef,
-      ],
-    },
-  ],
+  plugins: [],
 };
 
 export default mergeConfigs(

code-pushup.preset.ts

@@ -1,15 +1,18 @@
+import type {
+  CategoryConfig,
+  CoreConfig,
+} from './packages/models/src/index.js';
 import coveragePlugin, {
   getNxCoveragePaths,
-} from './dist/packages/plugin-coverage';
+} from './packages/plugin-coverage/src/index.js';
 import eslintPlugin, {
   eslintConfigFromAllNxProjects,
   eslintConfigFromNxProject,
-} from './dist/packages/plugin-eslint';
-import jsPackagesPlugin from './dist/packages/plugin-js-packages';
+} from './packages/plugin-eslint/src/index.js';
+import jsPackagesPlugin from './packages/plugin-js-packages/src/index.js';
 import lighthousePlugin, {
   lighthouseGroupRef,
-} from './dist/packages/plugin-lighthouse';
-import type { CategoryConfig, CoreConfig } from './packages/models/src';
+} from './packages/plugin-lighthouse/src/index.js';
 
 export const jsPackagesCategories: CategoryConfig[] = [
   {

e2e/ci-e2e/.eslintrc.json

@@ -1,6 +1,6 @@
 {
   "extends": ["../../.eslintrc.json"],
-  "ignorePatterns": ["!**/*", "code-pushup.config*.ts"],
+  "ignorePatterns": ["!**/*", "*.config*"],
   "overrides": [
     {
       "files": ["*.ts", "*.tsx"],

e2e/ci-e2e/vite.config.e2e.ts

@@ -1,6 +1,6 @@
 /// <reference types="vitest" />
 import { defineConfig } from 'vite';
-import { tsconfigPathAliases } from '../../tools/vitest-tsconfig-path-aliases';
+import { tsconfigPathAliases } from '../../tools/vitest-tsconfig-path-aliases.js';
 
 export default defineConfig({
   cacheDir: '../../node_modules/.vite/ci-e2e',

e2e/cli-e2e/.eslintrc.json

@@ -1,6 +1,6 @@
 {
   "extends": ["../../.eslintrc.json"],
-  "ignorePatterns": ["!**/*", "code-pushup.config*.ts"],
+  "ignorePatterns": ["!**/*", "*.config*"],
   "overrides": [
     {
       "files": ["*.ts", "*.tsx"],

e2e/cli-e2e/mocks/fixtures/dummy-setup/code-pushup.config.js

@@ -1,4 +1,4 @@
-import dummyPlugin, { dummyCategory } from './dummy.plugin';
+import dummyPlugin, { dummyCategory } from './dummy.plugin.js';
 
 export default {
   plugins: [dummyPlugin()],

e2e/cli-e2e/mocks/fixtures/dummy-setup/code-pushup.config.mjs

@@ -1,4 +1,4 @@
-import dummyPlugin, { dummyCategory } from './dummy.plugin';
+import dummyPlugin, { dummyCategory } from './dummy.plugin.js';
 
 export default {
   plugins: [dummyPlugin()],

e2e/cli-e2e/mocks/fixtures/dummy-setup/code-pushup.config.ts

@@ -1,4 +1,4 @@
-import dummyPlugin, { dummyCategory } from './dummy.plugin';
+import dummyPlugin, { dummyCategory } from './dummy.plugin.js';
 
 export default {
   plugins: [dummyPlugin()],

e2e/cli-e2e/mocks/fixtures/existing-reports/code-pushup.config.ts

@@ -1,4 +1,4 @@
-import dummyPlugin, { dummyCategory } from './dummy.plugin';
+import dummyPlugin, { dummyCategory } from './dummy.plugin.js';
 
 export default {
   plugins: [dummyPlugin()],

e2e/cli-e2e/vite.config.e2e.ts

@@ -1,6 +1,6 @@
 /// <reference types="vitest" />
 import { defineConfig } from 'vite';
-import { tsconfigPathAliases } from '../../tools/vitest-tsconfig-path-aliases';
+import { tsconfigPathAliases } from '../../tools/vitest-tsconfig-path-aliases.js';
 
 export default defineConfig({
   cacheDir: '../../node_modules/.vite/cli-e2e',

e2e/create-cli-e2e/.eslintrc.json

@@ -1,6 +1,6 @@
 {
   "extends": ["../../.eslintrc.json"],
-  "ignorePatterns": ["!**/*", "code-pushup.config*.ts"],
+  "ignorePatterns": ["!**/*", "*.config*"],
   "overrides": [
     {
       "files": ["*.ts", "*.tsx"],

e2e/create-cli-e2e/project.json

@@ -14,6 +14,7 @@
     "e2e": {
       "executor": "@nx/vite:test",
       "options": {
+        "keepServerRunning": true,
         "configFile": "e2e/create-cli-e2e/vite.config.e2e.ts"
       }
     }

e2e/create-cli-e2e/tests/init.e2e.test.ts

@@ -10,7 +10,10 @@ import {
 } from '@code-pushup/test-utils';
 import { executeProcess, readJsonFile, readTextFile } from '@code-pushup/utils';
 
-describe('create-cli-inti', () => {
+const fakeCacheFolderName = () =>
+  `fake-cache-${new Date().toISOString().replace(/[:.]/g, '-')}`;
+
+describe('create-cli-init', () => {
   const workspaceRoot = join(E2E_ENVIRONMENTS_DIR, nxTargetProject());
   const testFileDir = join(workspaceRoot, TEST_OUTPUT_DIR, 'init');
 
@@ -23,7 +26,12 @@ describe('create-cli-inti', () => {
     await createNpmWorkspace(cwd);
     const { code, stdout } = await executeProcess({
       command: 'npm',
-      args: ['exec', '@code-pushup/create-cli'],
+      args: [
+        'exec',
+        '--yes',
+        `--cache=${fakeCacheFolderName()}`,
+        '@code-pushup/create-cli',
+      ],
       cwd,
     });
 
@@ -58,7 +66,12 @@ describe('create-cli-inti', () => {
 
     const { code, stdout } = await executeProcess({
       command: 'npm',
-      args: ['init', '@code-pushup/cli'],
+      args: [
+        'init',
+        '--yes',
+        `--cache=${fakeCacheFolderName()}`,
+        '@code-pushup/cli',
+      ],
       cwd,
     });
 
@@ -87,13 +100,18 @@ describe('create-cli-inti', () => {
     );
   });
 
-  it('should produce an executable setup when running npm init', async () => {
-    const cwd = join(testFileDir, 'npm-init-executable');
+  it('should produce an executable setup when running npm exec', async () => {
+    const cwd = join(testFileDir, 'npm-executable');
     await createNpmWorkspace(cwd);
 
     await executeProcess({
       command: 'npm',
-      args: ['init', '@code-pushup/cli'],
+      args: [
+        'exec',
+        '--yes',
+        `--cache=${fakeCacheFolderName()}`,
+        '@code-pushup/create-cli',
+      ],
       cwd,
     });
 

e2e/create-cli-e2e/vite.config.e2e.ts

@@ -1,6 +1,6 @@
 /// <reference types="vitest" />
 import { defineConfig } from 'vite';
-import { tsconfigPathAliases } from '../../tools/vitest-tsconfig-path-aliases';
+import { tsconfigPathAliases } from '../../tools/vitest-tsconfig-path-aliases.js';
 
 export default defineConfig({
   cacheDir: '../../node_modules/.vite/create-cli-e2e',

e2e/nx-plugin-e2e/.eslintrc.json

@@ -1,6 +1,6 @@
 {
   "extends": ["../../.eslintrc.json"],
-  "ignorePatterns": ["!**/*", "code-pushup.config*.ts"],
+  "ignorePatterns": ["!**/*", "*.config*"],
   "overrides": [
     {
       "files": ["*.ts", "*.tsx"],

e2e/nx-plugin-e2e/tests/__snapshots__/plugin-create-nodes.e2e.test.ts.snap

@@ -6,6 +6,7 @@ exports[`nx-plugin > should NOT add config targets dynamically if the project is
     "configurations": {},
     "executor": "@code-pushup/nx-plugin:cli",
     "options": {},
+    "parallelism": true,
   },
 }
 `;
@@ -18,6 +19,7 @@ exports[`nx-plugin > should add configuration target dynamically 1`] = `
     "options": {
       "command": "nx g @code-pushup/nx-plugin:configuration --skipTarget --targetName="code-pushup" --project="my-lib"",
     },
+    "parallelism": true,
   },
 }
 `;
@@ -28,6 +30,7 @@ exports[`nx-plugin > should add executor target dynamically if the project is co
     "configurations": {},
     "executor": "@code-pushup/nx-plugin:cli",
     "options": {},
+    "parallelism": true,
   },
 }
 `;

e2e/nx-plugin-e2e/tests/executor-cli.e2e.test.ts

@@ -1,5 +1,5 @@
 import { type Tree, updateProjectConfiguration } from '@nx/devkit';
-import { join, relative } from 'node:path';
+import { join } from 'node:path';
 import { readProjectConfiguration } from 'nx/src/generators/utils/project-configuration';
 import { afterEach, expect } from 'vitest';
 import { generateCodePushupConfig } from '@code-pushup/nx-plugin';
@@ -12,21 +12,16 @@ import { teardownTestFolder } from '@code-pushup/test-setup';
 import {
   E2E_ENVIRONMENTS_DIR,
   TEST_OUTPUT_DIR,
-  osAgnosticPath,
   removeColorCodes,
 } from '@code-pushup/test-utils';
 import { executeProcess, readJsonFile } from '@code-pushup/utils';
-
-function relativePathToCwd(testDir: string): string {
-  return relative(join(process.cwd(), testDir), process.cwd());
-}
+import { INLINE_PLUGIN } from './inline-plugin.js';
 
 async function addTargetToWorkspace(
   tree: Tree,
   options: { cwd: string; project: string },
 ) {
   const { cwd, project } = options;
-  const pathRelativeToPackage = relative(join(cwd, 'libs', project), cwd);
   const projectCfg = readProjectConfiguration(tree, project);
   updateProjectConfiguration(tree, project, {
     ...projectCfg,
@@ -39,18 +34,10 @@ async function addTargetToWorkspace(
   });
   const { root } = projectCfg;
   generateCodePushupConfig(tree, root, {
-    fileImports: `import type {CoreConfig} from "@code-pushup/models";`,
     plugins: [
       {
-        // @TODO replace with inline plugin
-        fileImports: `import {customPlugin} from "${osAgnosticPath(
-          join(
-            relativePathToCwd(cwd),
-            pathRelativeToPackage,
-            'dist/testing/test-utils',
-          ),
-        )}";`,
-        codeStrings: 'customPlugin()',
+        fileImports: '',
+        codeStrings: INLINE_PLUGIN,
       },
     ],
   });

e2e/nx-plugin-e2e/tests/inline-plugin.ts

@@ -0,0 +1,21 @@
+export const INLINE_PLUGIN = `
+  {
+    slug: 'good-feels',
+    title: 'Good feels',
+    icon: 'javascript',
+    audits: [
+      {
+        slug: 'always-perfect',
+        title: 'Always perfect',
+      },
+    ],
+    runner: () => [
+      {
+        slug: 'always-perfect',
+        score: 1,
+        value: 100,
+        displayValue: '✅ Perfect! 👌',
+      },
+    ],
+  }
+`;