Refactor code following dart analyze suggested by dart lints

Author: code-shoily

analysis_options.yaml

@@ -1,79 +1 @@
-analyzer:
-#   exclude:
-#     - path/to/excluded/files/**
-
-# Lint rules and documentation, see http://dart-lang.github.io/linter/lints
-# NOTE: The contents of `Effective Dart` have been copied over because it does not yet support NNBD
-
-linter:
-  rules:
-    # STYLE
-    - camel_case_types
-    - camel_case_extensions
-    - library_names
-    - file_names
-    - library_prefixes
-    - non_constant_identifier_names
-    - constant_identifier_names # prefer
-    - directives_ordering
-    - lines_longer_than_80_chars # avoid
-    - curly_braces_in_flow_control_structures
-    - prefer_single_quotes
-
-    # DOCUMENTATION
-    - slash_for_doc_comments
-    - package_api_docs # prefer
-    - public_member_api_docs # prefer
-    #- comment_references # Unused because https://github.com/dart-lang/sdk/issues/36974
-
-    # USAGE
-    - implementation_imports
-    - avoid_relative_lib_imports
-    - prefer_relative_imports
-    - prefer_adjacent_string_concatenation
-    - prefer_interpolation_to_compose_strings # prefer
-    - unnecessary_brace_in_string_interps # avoid
-    - prefer_collection_literals
-    - prefer_is_empty
-    - prefer_is_not_empty
-    - avoid_function_literals_in_foreach_calls # avoid
-    - prefer_iterable_whereType
-    - prefer_function_declarations_over_variables
-    - unnecessary_lambdas
-    - prefer_equal_for_default_values
-    - avoid_init_to_null
-    - unnecessary_getters_setters
-    #- unnecessary_getters # prefer # Disabled pending fix: https://github.com/dart-lang/linter/issues/23
-    #- prefer_expression_function_bodies # consider
-    - unnecessary_this
-    - prefer_initializing_formals
-    - type_init_formals
-    - empty_constructor_bodies
-    - unnecessary_new
-    - unnecessary_const
-    - avoid_catches_without_on_clauses # avoid
-    - avoid_catching_errors
-    - use_rethrow_when_possible
-
-    # DESIGN
-    - use_to_and_as_if_applicable # prefer
-    - one_member_abstracts # avoid
-    - avoid_classes_with_only_static_members # avoid
-    - prefer_mixin
-    - prefer_final_fields # prefer
-    - use_setters_to_change_properties
-    - avoid_setters_without_getters
-    - avoid_returning_null # avoid
-    - avoid_returning_this # avoid
-    - type_annotate_public_apis # prefer
-    #- prefer_typing_uninitialized_variables # consider
-    - omit_local_variable_types # avoid
-    #- avoid_types_on_closure_parameters # avoid
-    - avoid_return_types_on_setters
-    - prefer_generic_function_type_aliases
-    - avoid_private_typedef_functions # prefer
-    #- use_function_type_syntax_for_parameters # consider
-    - avoid_positional_boolean_parameters # avoid
-    - hash_and_equals
-    - avoid_equals_and_hash_code_on_mutable_classes # avoid
-    - avoid_null_checks_in_equality_operators
+include: package:lints/recommended.yaml

lib/graph/vertex.dart

@@ -73,8 +73,10 @@ class Vertex<T> {
   String toString() => key;
 
   // ignore: avoid_equals_and_hash_code_on_mutable_classes
+  @override
   bool operator ==(Object other) => other is Vertex && key == other.key;
 
   // ignore: avoid_equals_and_hash_code_on_mutable_classes
+  @override
   int get hashCode => key.hashCode;
 }

lib/lists/circular_doubly_linked_list.dart

@@ -48,9 +48,7 @@ class CircularDoublyLinkedList<T> {
     if (n < 0) throw InvalidIndexError();
 
     var currentNode = head;
-    for (var i = 0; i < n; i++, currentNode = currentNode!.next) {
-      ;
-    }
+    for (var i = 0; i < n; i++, currentNode = currentNode!.next) {}
 
     return currentNode!;
   }

lib/lists/circular_singly_linked_list.dart

@@ -45,9 +45,7 @@ class CircularSinglyLinkedList<T> {
     if (n < 0) throw InvalidIndexError();
 
     var currentNode = head;
-    for (var i = 0; i < n; i++, currentNode = currentNode!.next) {
-      ;
-    }
+    for (var i = 0; i < n; i++, currentNode = currentNode!.next) {}
 
     return currentNode!;
   }

lib/sorts/exchange.dart

@@ -60,7 +60,7 @@ List<T> gnomeSort<T extends Comparable>(List<T> list,
 /// Quick Sort
 List<T> quickSort<T extends Comparable>(List<T> list,
     [Comparator<T> compareFn = ascendingFn]) {
-  int _partition(List<T> list, int low, int high) {
+  int partition(List<T> list, int low, int high) {
     var pivot = list[high], i = low;
 
     for (var j = low; j < high; j++) {
@@ -73,14 +73,14 @@ List<T> quickSort<T extends Comparable>(List<T> list,
     return i;
   }
 
-  void _sort(List<T> list, int low, int high) {
+  void sort(List<T> list, int low, int high) {
     if (low < high) {
-      var p = _partition(list, low, high);
-      _sort(list, low, p - 1);
-      _sort(list, p + 1, high);
+      var p = partition(list, low, high);
+      sort(list, low, p - 1);
+      sort(list, p + 1, high);
     }
   }
 
-  _sort(list, 0, list.length - 1);
+  sort(list, 0, list.length - 1);
   return list;
 }

lib/sorts/merge.dart

@@ -3,7 +3,7 @@ import 'common.dart';
 /// Implement Merge Sort.
 List<T> mergeSort<T extends Comparable>(List<T> list,
     [Comparator<T> compareFn = ascendingFn]) {
-  void _merge(
+  void merge(
       List<T> list, int left, int middle, int right, Comparator<T> compareFn) {
     var leftList = list.sublist(left, middle + 1);
     var rightList = list.sublist(middle + 1, right + 1);
@@ -30,18 +30,18 @@ List<T> mergeSort<T extends Comparable>(List<T> list,
     }
   }
 
-  void _mergeSort(List<T> list, int left, int right, Comparator<T> compareFn) {
+  void mergeSort(List<T> list, int left, int right, Comparator<T> compareFn) {
     if (right > left) {
       var middle = (left + right) ~/ 2;
 
-      _mergeSort(list, left, middle, compareFn);
-      _mergeSort(list, middle + 1, right, compareFn);
+      mergeSort(list, left, middle, compareFn);
+      mergeSort(list, middle + 1, right, compareFn);
 
-      _merge(list, left, middle, right, compareFn);
+      merge(list, left, middle, right, compareFn);
     }
   }
 
-  _mergeSort(list, 0, list.length - 1, compareFn);
+  mergeSort(list, 0, list.length - 1, compareFn);
 
   return list;
 }

lib/trees/adt/binary_tree_adt.dart

@@ -4,6 +4,7 @@ import 'tree_adt.dart';
 abstract class BinaryNodeADT<N extends BinaryNodeADT<N, V>,
     V extends Comparable> implements NodeADT<N, V> {
   /// Binary node only has two children, [left] and [right].
+  @override
   List<N?>? children = List<N?>.filled(2, null);
 
   /// Left child node.

lib/trees/avl_tree.dart

@@ -15,6 +15,7 @@ class AvlNode<V extends Comparable> extends BinaryNodeADT<AvlNode<V>, V> {
   int balanceFactor = 0;
 
   /// [value] of the [node].
+  @override
   V? value;
 
   /// Creates an empty [AvlNode].
@@ -30,6 +31,7 @@ class AvlNode<V extends Comparable> extends BinaryNodeADT<AvlNode<V>, V> {
 /// of any [node] can be at most `1`.
 class AvlTree<V extends Comparable> extends BinaryTreeADT<AvlNode<V>, V> {
   /// Root of the tree.
+  @override
   AvlNode<V>? root;
 
   /// If after addition, height of parent node increases and results in an

lib/trees/binary_search_tree.dart

@@ -10,6 +10,7 @@ import 'binary_tree.dart';
 class BinarySearchTree<V extends Comparable>
     extends BinaryTreeADT<BinaryNode<V>, V> {
   /// Root of the tree
+  @override
   BinaryNode<V>? root;
 
   /// Creates an empty BST.

lib/trees/binary_tree.dart

@@ -3,6 +3,7 @@ import 'adt/binary_tree_adt.dart';
 /// A binary node has at most two children, which are referred to as the
 ///  [left] child and the [right] child.
 class BinaryNode<V extends Comparable> extends BinaryNodeADT<BinaryNode<V>, V> {
+  @override
   V? value;
 
   /// Creates a node with [value].