[pull] main from facebook:main

.eslintrc.js

@@ -496,6 +496,7 @@ module.exports = {
     {
       files: [
         'packages/react-devtools-extensions/**/*.js',
+        'packages/react-devtools-shared/src/devtools/views/**/*.js',
         'packages/react-devtools-shared/src/hook.js',
         'packages/react-devtools-shared/src/backend/console.js',
         'packages/react-devtools-shared/src/backend/shared/DevToolsComponentStackFrame.js',

.github/workflows/compiler_discord_notify.yml

@@ -0,0 +1,24 @@
+name: (Compiler) Discord Notify
+
+on:
+  pull_request_target:
+    types: [labeled]
+    paths:
+      - compiler/**
+      - .github/workflows/compiler_**.yml
+
+jobs:
+  notify:
+    if: ${{ github.event.label.name == 'React Core Team' }}
+    runs-on: ubuntu-latest
+    steps:
+      - name: Discord Webhook Action
+        uses: tsickert/discord-webhook@v6.0.0
+        with:
+          webhook-url: ${{ secrets.COMPILER_DISCORD_WEBHOOK_URL }}
+          embed-author-name: ${{ github.event.pull_request.user.login }}
+          embed-author-url: ${{ github.event.pull_request.user.html_url }}
+          embed-author-icon-url: ${{ github.event.pull_request.user.avatar_url }}
+          embed-title: '#${{ github.event.number }} (+${{github.event.pull_request.additions}} -${{github.event.pull_request.deletions}}): ${{ github.event.pull_request.title }}'
+          embed-description: ${{ github.event.pull_request.body }}
+          embed-url: ${{ github.event.pull_request.html_url }}

.github/workflows/runtime_build_and_test.yml

@@ -416,7 +416,6 @@ jobs:
       - name: Ensure clean build directory
         run: rm -rf build
       - run: yarn install --frozen-lockfile
-      - run: yarn install --frozen-lockfile --cache-folder ~/.cache/yarn
         working-directory: fixtures/dom
       - name: Restore archived build
         uses: actions/download-artifact@v4

.github/workflows/runtime_discord_notify.yml

@@ -0,0 +1,24 @@
+name: (Runtime) Discord Notify
+
+on:
+  pull_request_target:
+    types: [labeled]
+    paths-ignore:
+      - compiler/**
+      - .github/workflows/compiler_**.yml
+
+jobs:
+  notify:
+    if: ${{ github.event.label.name == 'React Core Team' }}
+    runs-on: ubuntu-latest
+    steps:
+      - name: Discord Webhook Action
+        uses: tsickert/discord-webhook@v6.0.0
+        with:
+          webhook-url: ${{ secrets.DISCORD_WEBHOOK_URL }}
+          embed-author-name: ${{ github.event.pull_request.user.login }}
+          embed-author-url: ${{ github.event.pull_request.user.html_url }}
+          embed-author-icon-url: ${{ github.event.pull_request.user.avatar_url }}
+          embed-title: '#${{ github.event.number }} (+${{github.event.pull_request.additions}} -${{github.event.pull_request.deletions}}): ${{ github.event.pull_request.title }}'
+          embed-description: ${{ github.event.pull_request.body }}
+          embed-url: ${{ github.event.pull_request.html_url }}

compiler/packages/react-compiler-runtime/scripts/build.js

@@ -13,11 +13,6 @@ const path = require('path');
 const {Generator} = require('npm-dts');
 
 const argv = yargs(process.argv.slice(2))
-  .options('p', {
-    alias: 'platform',
-    default: 'browser',
-    choices: ['browser', 'node'],
-  })
   .options('w', {
     alias: 'watch',
     default: false,
@@ -31,7 +26,7 @@ const config = {
   bundle: true,
   external: ['react'],
   format: 'cjs',
-  platform: argv.p,
+  platform: 'node',
   target: 'es6',
   banner: {
     js: `/**

compiler/packages/snap/package.json

@@ -10,7 +10,7 @@
   ],
   "scripts": {
     "postinstall": "./scripts/link-react-compiler-runtime.sh && perl -p -i -e 's/react\\.element/react.transitional.element/' ../../node_modules/fbt/lib/FbtReactUtil.js && perl -p -i -e 's/didWarnAboutUsingAct = false;/didWarnAboutUsingAct = true;/' ../../node_modules/react-dom/cjs/react-dom-test-utils.development.js",
-    "build": "rimraf dist && concurrently -n snap,runtime \"tsc --build\" \"yarn --silent workspace react-compiler-runtime build -p node\"",
+    "build": "rimraf dist && concurrently -n snap,runtime \"tsc --build\" \"yarn --silent workspace react-compiler-runtime build\"",
     "test": "echo 'no tests'",
     "prettier": "prettier --write 'src/**/*.ts'"
   },

fixtures/dom/package.json

@@ -14,13 +14,13 @@
     "jest-diff": "^29.4.1",
     "prop-types": "^15.6.0",
     "query-string": "^4.2.3",
-    "react": "^15.4.1",
-    "react-dom": "^15.4.1",
+    "react": "^19.0.0",
+    "react-dom": "^19.0.0",
     "semver": "^5.5.0"
   },
   "scripts": {
     "dev": "react-scripts start",
-    "predev": "cp -a ../../build/oss-stable/. node_modules",
+    "predev": "cp -a ../../build/oss-experimental/. node_modules",
     "build": "react-scripts build && cp build/index.html build/200.html",
     "test": "react-scripts test --env=jsdom",
     "eject": "react-scripts eject"

fixtures/dom/src/index.js

@@ -1,21 +1,42 @@
 import './polyfills';
-import loadReact from './react-loader';
+import loadReact, {isLocal} from './react-loader';
 
-loadReact()
-  .then(() => import('./components/App'))
-  .then(App => {
-    const {React, ReactDOM} = window;
-
-    if (typeof window.ReactDOMClient !== 'undefined') {
-      // we are in a React that only supports modern roots
-
-      ReactDOM.createRoot(document.getElementById('root')).render(
-        React.createElement(App.default)
+if (isLocal()) {
+  Promise.all([import('react'), import('react-dom/client')])
+    .then(([React, ReactDOMClient]) => {
+      if (React === undefined || ReactDOMClient === undefined) {
+        throw new Error(
+          'Unable to load React. Build experimental and then run `yarn dev` again'
+        );
+      }
+      window.React = React;
+      window.ReactDOMClient = ReactDOMClient;
+    })
+    .then(() => import('./components/App'))
+    .then(App => {
+      window.ReactDOMClient.createRoot(document.getElementById('root')).render(
+        window.React.createElement(App.default)
       );
-    } else {
-      ReactDOM.render(
-        React.createElement(App.default),
-        document.getElementById('root')
-      );
-    }
-  });
+    });
+} else {
+  loadReact()
+    .then(() => import('./components/App'))
+    .then(App => {
+      const {React, ReactDOM} = window;
+      if (
+        typeof window.ReactDOMClient !== 'undefined' &&
+        typeof window.ReactDOMClient.createRoot !== 'undefined'
+      ) {
+        // we are in a React that only supports modern roots
+
+        window.ReactDOMClient.createRoot(
+          document.getElementById('root')
+        ).render(React.createElement(App.default));
+      } else {
+        ReactDOM.render(
+          React.createElement(App.default),
+          document.getElementById('root')
+        );
+      }
+    });
+}

fixtures/dom/src/react-loader.js

@@ -68,6 +68,10 @@ function getVersion() {
   return query.version || 'local';
 }
 
+export function isLocal() {
+  return getVersion() === 'local';
+}
+
 export function reactPaths(version = getVersion()) {
   let query = parseQuery(window.location.search);
   let isProduction = query.production === 'true';