Skip to content

Conversation

@raphael-goetz
Copy link
Member

Resolves: #151

  • added alias and displayMessage to every definition
  • renamed every occurrence of array to list

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request adds alias and displayMessage fields to all definition files and renames all occurrences of "ARRAY" to "LIST" throughout the codebase. The changes aim to improve searchability and user-facing display messages for runtime definitions and data types.

Key changes:

  • Added alias and displayMessage fields to runtime definitions, data types, and flow types
  • Renamed data type identifier from "ARRAY" to "LIST" across all definitions
  • Updated tucana dependency from 0.0.40 to 0.0.41 in Cargo.toml

Reviewed Changes

Copilot reviewed 132 out of 133 changed files in this pull request and generated 8 comments.

Show a summary per file
File Description
definitions/standard/runtime_definition/text/*.proto.json Added alias/displayMessage to text operations
definitions/standard/runtime_definition/number/*.proto.json Added alias/displayMessage to number operations
definitions/standard/runtime_definition/array/*.proto.json Renamed array to list, added alias/displayMessage
definitions/standard/runtime_definition/boolean/*.proto.json Added alias/displayMessage to boolean operations
definitions/standard/runtime_definition/control/*.proto.json Added alias/displayMessage to control flow operations
definitions/standard/runtime_definition/object/*.proto.json Added alias/displayMessage to object operations
definitions/standard/data_type/**/*.proto.json Added alias/displayMessage, renamed ARRAY to LIST
definitions/http/**/*.proto.json Added alias/displayMessage to HTTP-related definitions
Cargo.toml/Cargo.lock Updated tucana dependency version

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 132 out of 133 changed files in this pull request and generated 8 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

raphael-goetz and others added 5 commits November 20, 2025 18:25
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Raphael Götz <52959657+raphael-goetz@users.noreply.github.com>
….proto.json

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Raphael Götz <52959657+raphael-goetz@users.noreply.github.com>
…to.json

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Raphael Götz <52959657+raphael-goetz@users.noreply.github.com>
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 132 out of 133 changed files in this pull request and generated 20 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 132 out of 133 changed files in this pull request and generated 6 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 132 out of 133 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@raphael-goetz raphael-goetz merged commit 589d784 into main Nov 26, 2025
12 checks passed
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 132 out of 133 changed files in this pull request and generated 8 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

"displayMessage": [
{
"code": "en-US",
"content": "On ${method} request to ${route}"
Copy link

Copilot AI Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The displayMessage references ${method} and ${route}, but these identifiers don't match the actual setting identifiers defined in the file (HTTP_METHOD and HTTP_URL). This will likely cause display issues.

Suggested change
"content": "On ${method} request to ${route}"
"content": "On ${HTTP_METHOD} request to ${HTTP_URL}"

Copilot uses AI. Check for mistakes.
"alias": [
{
"code": "en-US",
"content": "to text;string;format number;boolean;logic;std;as;text"
Copy link

Copilot AI Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The alias "format number" in this boolean conversion function is misleading - it suggests number formatting rather than boolean-to-text conversion.

Copilot uses AI. Check for mistakes.
Comment on lines +10 to +21
"alias": [
{
"code": "en-US",
"content": "text;char;literal;string"
}
],
"displayMessage": [
{
"code": "en-US",
"content": "Text"
}
],
Copy link

Copilot AI Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent indentation: using tabs in some places and spaces in others. The file should use consistent indentation throughout.

Suggested change
"alias": [
{
"code": "en-US",
"content": "text;char;literal;string"
}
],
"displayMessage": [
{
"code": "en-US",
"content": "Text"
}
],
"alias": [
{
"code": "en-US",
"content": "text;char;literal;string"
}
],
"displayMessage": [
{
"code": "en-US",
"content": "Text"
}
],

Copilot uses AI. Check for mistakes.
Comment on lines +10 to +21
"alias": [
{
"code": "en-US",
"content": "number;integer;float;double;long"
}
],
"displayMessage": [
{
"code": "en-US",
"content": "Number"
}
],
Copy link

Copilot AI Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent indentation: using tabs in some places and spaces in others. The file should use consistent indentation throughout.

Suggested change
"alias": [
{
"code": "en-US",
"content": "number;integer;float;double;long"
}
],
"displayMessage": [
{
"code": "en-US",
"content": "Number"
}
],
"alias": [
{
"code": "en-US",
"content": "number;integer;float;double;long"
}
],
"displayMessage": [
{
"code": "en-US",
"content": "Number"
}
],

Copilot uses AI. Check for mistakes.
Comment on lines +10 to +21
"alias": [
{
"code": "en-US",
"content": "bool;boolean;bit"
}
],
"displayMessage": [
{
"code": "en-US",
"content": "Boolean"
}
],
Copy link

Copilot AI Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent indentation: using tabs in some places and spaces in others. The file should use consistent indentation throughout.

Suggested change
"alias": [
{
"code": "en-US",
"content": "bool;boolean;bit"
}
],
"displayMessage": [
{
"code": "en-US",
"content": "Boolean"
}
],
"alias": [
{
"code": "en-US",
"content": "bool;boolean;bit"
}
],
"displayMessage": [
{
"code": "en-US",
"content": "Boolean"
}
],

Copilot uses AI. Check for mistakes.
Comment on lines +10 to +21
"alias": [
{
"code": "en-US",
"content": "object;struct;data"
}
],
"displayMessage": [
{
"code": "en-US",
"content": "Object"
}
],
Copy link

Copilot AI Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent indentation: using tabs in some places and spaces in others. The file should use consistent indentation throughout.

Suggested change
"alias": [
{
"code": "en-US",
"content": "object;struct;data"
}
],
"displayMessage": [
{
"code": "en-US",
"content": "Object"
}
],
"alias": [
{
"code": "en-US",
"content": "object;struct;data"
}
],
"displayMessage": [
{
"code": "en-US",
"content": "Object"
}
],

Copilot uses AI. Check for mistakes.
"displayMessage": [
{
"code": "en-US",
"content": "cos(${radians})"
Copy link

Copilot AI Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The displayMessage incorrectly references parameter ${radians}, but the parameter is named value (line 8). This will cause the display message to not interpolate correctly.

Copilot uses AI. Check for mistakes.
"displayMessage": [
{
"code": "en-US",
"content": "tan(${radians})"
Copy link

Copilot AI Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The displayMessage incorrectly references parameter ${radians}, but the parameter is named value (line 8). This will cause the display message to not interpolate correctly.

Copilot uses AI. Check for mistakes.
@raphael-goetz raphael-goetz deleted the 151-add-alias-and-display branch December 3, 2025 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Alias and DisplayName to every definitions

2 participants