Skip to content

Alert Component #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Dec 14, 2023
Merged

Alert Component #11

merged 9 commits into from
Dec 14, 2023

Conversation

@nicosammito
Copy link
Contributor

Implementation of Alert component as described in #9 with just some adjustments made.

@nicosammito nicosammito added the enhancement New feature or request label Dec 13, 2023
@nicosammito nicosammito self-assigned this Dec 13, 2023
@nicosammito nicosammito linked an issue Dec 13, 2023 that may be closed by this pull request
Alert Component #9
Closed
@github-actions
Copy link
Contributor

github-actions bot commented Dec 13, 2023 •
edited
Loading

GitLab Pipeline Action

General information

Link to pipeline: https://gitlab.com/code0-tech/base-ui/-/pipelines/1106164586

Status: Passed
Duration: 48 seconds

Job summaries

storybook:build

Storybook available at https://code0-tech.gitlab.io/-/base-ui/-/jobs/5747452094/artifacts/storybook-static/index.html

@nicosammito nicosammito marked this pull request as draft December 13, 2023 09:41
@nicosammito
Copy link
Contributor Author

Still need to add the alert component without Body => therefore draft

Taucher2003
Taucher2003 reviewed Dec 13, 2023
View reviewed changes
Copy link
Member

@Taucher2003 Taucher2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me (not approving yet since you mentioned that some work still needs to be done)

@nicosammito nicosammito marked this pull request as ready for review December 13, 2023 21:47
@nicosammito nicosammito merged commit b478cda into main Dec 14, 2023
@nicosammito nicosammito deleted the alert branch December 14, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Taucher2003 Taucher2003 Taucher2003 approved these changes

Assignees

@nicosammito nicosammito

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Alert Component

3 participants

@nicosammito @Taucher2003