Skip to content

Conversation

@Knerio
Copy link
Member

@Knerio Knerio commented Oct 24, 2025

close #631

@Knerio Knerio requested a review from Taucher2003 October 24, 2025 14:28
@Knerio Knerio self-assigned this Oct 24, 2025
@Knerio Knerio changed the title Add name field Add name field for flow Oct 24, 2025
@github-actions
Copy link

github-actions bot commented Oct 24, 2025

GitLab Pipeline Action

General information

Link to pipeline: https://gitlab.com/code0-tech/development/sagittarius/-/pipelines/2137341829

Status: Passed
Duration: 5 minutes

Job summaries

rspec: [ee]

Coverage report available at https://code0-tech.gitlab.io/-/development/sagittarius/-/jobs/11954979666/artifacts/tmp/coverage/index.html
Test summary available at https://gitlab.com/code0-tech/development/sagittarius/-/pipelines/2137341829/test_report
Finished in 21.76 seconds (files took 11.65 seconds to load)
1192 examples, 0 failures
Line Coverage: 91.15% (3947 / 4330)
[TEST PROF INFO] Time spent in factories: 00:12.740 (46.01% of total time)

rspec: [ce]

Coverage report available at https://code0-tech.gitlab.io/-/development/sagittarius/-/jobs/11954979664/artifacts/tmp/coverage/index.html
Test summary available at https://gitlab.com/code0-tech/development/sagittarius/-/pipelines/2137341829/test_report
Finished in 21.74 seconds (files took 11.66 seconds to load)
1145 examples, 0 failures
Line Coverage: 90.52% (3782 / 4178)
[TEST PROF INFO] Time spent in factories: 00:12.373 (43.49% of total time)

rubocop

659 files inspected, no offenses detected

@Taucher2003
Copy link
Member

Something is very wrong with the git history in this branch. It contains commits from me and the diff shows a lot of unrelated changes.

@nicosammito
Copy link
Contributor

This is currently blocking code0-tech/pictor#436. Need new types version.

@Knerio
Copy link
Member Author

Knerio commented Nov 3, 2025

The pipeline should pass now, waiting for @Taucher2003 review and then it should be avaiable

@Knerio Knerio requested a review from Taucher2003 November 3, 2025 17:32
@Taucher2003 Taucher2003 enabled auto-merge November 3, 2025 17:33
@Knerio Knerio force-pushed the add-name-field branch 3 times, most recently from c9658dd to cd42d46 Compare November 3, 2025 17:46
@Taucher2003 Taucher2003 merged commit 65144a9 into main Nov 3, 2025
1 check passed
@Taucher2003 Taucher2003 deleted the add-name-field branch November 3, 2025 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing name field on Flow object

4 participants