Skip to content

Make email nullable in case the user isnt authorized to query it #703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 20, 2025
Merged

Make email nullable in case the user isnt authorized to query it #703

merged 1 commit into from
Nov 20, 2025

Conversation

@Knerio
Copy link
Member

@Knerio Knerio commented Nov 19, 2025

No description provided.

@Knerio Knerio requested a review from Taucher2003 November 19, 2025 13:10
@Knerio Knerio self-assigned this Nov 19, 2025
@github-actions
Copy link

github-actions bot commented Nov 19, 2025 •
edited
Loading

GitLab Pipeline Action

General information

Link to pipeline: https://gitlab.com/code0-tech/development/sagittarius/-/pipelines/2167875817

Status: Passed
Duration: 4 minutes

Job summaries

rspec: [ee]

Coverage report available at https://code0-tech.gitlab.io/-/development/sagittarius/-/jobs/12145085104/artifacts/tmp/coverage/index.html
Test summary available at https://gitlab.com/code0-tech/development/sagittarius/-/pipelines/2167875817/test_report
Finished in 20.86 seconds (files took 11.51 seconds to load)
1189 examples, 0 failures
Line Coverage: 91.32% (4039 / 4423)
[TEST PROF INFO] Time spent in factories: 00:10.884 (39.88% of total time)

rspec: [ce]

Coverage report available at https://code0-tech.gitlab.io/-/development/sagittarius/-/jobs/12145085102/artifacts/tmp/coverage/index.html
Test summary available at https://gitlab.com/code0-tech/development/sagittarius/-/pipelines/2167875817/test_report
Finished in 18.75 seconds (files took 9.07 seconds to load)
1142 examples, 0 failures
Line Coverage: 90.7% (3871 / 4268)
[TEST PROF INFO] Time spent in factories: 00:10.013 (41.81% of total time)

rubocop

670 files inspected, no offenses detected

Taucher2003
Taucher2003 reviewed Nov 19, 2025
View reviewed changes
@Knerio Knerio force-pushed the fix-nullable-email-if-not-authorized branch from ea7cd3a to dbcf98c Compare November 19, 2025 15:33
@Knerio Knerio requested a review from Taucher2003 November 19, 2025 15:33
@Knerio @Taucher2003
Make email nullable in case the user isnt authorized to query it
a00b50e 
Co-authored-by: Niklas van Schrick <mc.taucher2003@gmail.com>
Signed-off-by: Dario Pranjic <96529060+Knerio@users.noreply.github.com>
@Knerio Knerio force-pushed the fix-nullable-email-if-not-authorized branch from dbcf98c to a00b50e Compare November 19, 2025 15:34
@Taucher2003 Taucher2003 merged commit 2effaa8 into main Nov 20, 2025
1 check passed
@Taucher2003 Taucher2003 deleted the fix-nullable-email-if-not-authorized branch November 20, 2025 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Taucher2003 Taucher2003 Taucher2003 approved these changes

Assignees

@Knerio Knerio

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Knerio @Taucher2003