Apply changes for GenericCombinationStrategy to FunctionGenericMapper

[Knerio]

No description provided.

[raphael-goetz]

In what scenario is the strategy undefined?

[Knerio]

In what scenario is the strategy undefined?

In no scenario, i can just be an empty array

[raphael-goetz]

If it has no case what is the purpose of having it?

[Knerio]

Oh, you mean UNKNOWN. Thats if the grpc client uses an outdated version, it always sends 0 (UNKNOWN). In sagittarius for example we just throw an error if thats the case

[raphael-goetz]

How can this be 'unkown' ??? Just reject if it doesn't match expected behavior. How should it be handled then?

[Knerio]

The problem is the default value is 0, so we need to put something as 0 to handle these cases. The same applies to DataType variants

tucana/proto/shared/shared.data_type.proto

Line 16 in a2b262f

UNKNOWN = 0;

[raphael-goetz]

But why set a default. The datatypes you will receive never has an unknown.

If its unknown the value that's send to you would be wrong and shouldn't be even saved

[Knerio]

Yeah and the same logic applies to the strategies. If sagittarius has a newer version with one strategy more. then you will receive unknown