Separate messages for definition and execution #107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will these changes affect sagittarius? Will the models change? Or will it just be a new way of retrieving/sending data to the runtime? |
|
@Knerio No changes to the database, only to the messages. We will need to adjust the services in Sagittarius that write the data into the database, but it shouldn't need to change the database models |
|
Yea, all messages starting with "Execution" are sent by Sagittarius itself, all messages starting with "Definition" will be sent to Sagittarius. The reason is, definitions are containing generics, which I can't handle inside of the execution. Removing them is the most error proof solution |
raphael-goetz
approved these changes
Jun 3, 2025
raphael-goetz
deleted the
106-remove-generics-from-messages-sent-to-runtime
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #106