Fix ruby implementation #163
Conversation
Knerio
force-pushed
the
162-genericmapperto_h-is-implemented-incorrectly
branch
from
a3f7e18 to
8736b99
Compare
Taucher2003
deleted the
162-genericmapperto_h-is-implemented-incorrectly
branch
There was a problem hiding this comment.
Pull request overview
This PR fixes the serialization of the source field in the GenericMapper class by correctly mapping over an array of DataTypeIdentifier objects. According to the protobuf definition (repeated DataTypeIdentifier source = 1), source is an array, not a single object.
- Changed
self.source.to_htoself.source.map(&:to_h)to properly serialize the array
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| { | ||
| target: self.target, | ||
| source: self.source.to_h, | ||
| source: self.source.map(&:to_h), |
There was a problem hiding this comment.
The fix to use self.source.map(&:to_h) is correct based on the protobuf definition (line 155: repeated DataTypeIdentifier source = 1), but the corresponding from_hash method on line 248 is inconsistent. Line 248 treats source as a single object: self.source = DataTypeIdentifier.from_hash(config.fetch(:source)), but it should map over an array like:
self.source = config.fetch(:source).map { |s| DataTypeIdentifier.from_hash(s) }This inconsistency will cause serialization to work but deserialization to fail.
No description provided.