Add tests for formatters #190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remnantdotdev
force-pushed
the
format-tests
branch
from
1cfe121 to
64c99a5
Compare
|
looks great! def makes sense to break up format and data. think the previous commit caused a small conflict in one file |
joshreisner
approved these changes
Feb 7, 2022
joshreisner
added a commit
that referenced
this pull request
Jun 2, 2023
* Add tests for formatters * Add more tests / break into individual files * Use global tz for tests * Run tests before prod build Co-authored-by: Josh Reisner <1551689+joshreisner@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@joshreisner The tests were getting a little hard to parse all being in one file so I ended up splitting them out, let me know what you think. We might have to do the same with
data.js👀