Skip to content

Conversation

tiptop96
Copy link
Collaborator

@tiptop96 tiptop96 commented Mar 3, 2023

No description provided.

@netlify
Copy link

netlify bot commented Mar 3, 2023

Deploy Preview for tsml-ui ready!

Name Link
🔨 Latest commit c615715
🔍 Latest deploy log https://app.netlify.com/sites/tsml-ui/deploys/6401fd369dbac4000898b8bc
😎 Deploy Preview https://deploy-preview-296--tsml-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@tiptop96
Copy link
Collaborator Author

tiptop96 commented Mar 3, 2023

Hey!

We anticipate a usecase where there is only one region making the filter redundant so it would be cool to be able to override them.

Another possible solution would be too have the possibility to disable the filter if there is only one possible value.

What are your thoughts?

@joshreisner
Copy link
Contributor

could you tell me more about this use-case? it's currently possible to hide the region dropdown if you don't have any region or city keys in your data

@tiptop96
Copy link
Collaborator Author

tiptop96 commented Mar 3, 2023

Ahh I miss-understood the field, after some experimentation I realise I have no use-case 😅. But that is good to know. I think we can scrap this PR.

@tiptop96 tiptop96 closed this Mar 3, 2023
@joshreisner
Copy link
Contributor

ok! i'm not opposed to bringing it back someday if you wanted to be able to re-order the controls.

Another possible solution would be too have the possibility to disable the filter if there is only one possible value.

yes, it might make sense to hide any filter (including time, day, etc) if it applies to every meeting in the list, since it would not be an aid to searching, and just be clutter. in the case of your single region, that would result in the region filter being hidden without having to change the config.

@tiptop96
Copy link
Collaborator Author

tiptop96 commented Mar 3, 2023

Cool! My initial thought on reordering is that it could confuse users visiting different sites.

The point about clutter still hold true, but idk how common this is. I don't know why but I thought it would only be "correct" to put the area name in region which is paradoxical as there will always only be one area per area. 😅

Now I set it up to use district for region and city for sub_region, this makes more sense and provides useful search parameters and is likely to give a good range for every area. So we will probably not have a need for it with that strategy. But we will see how well that plan holds up as we onboard more people. Does that approach seem sensible to you?

@joshreisner
Copy link
Contributor

sounds great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants