Skip to content

Conversation

@phrdang
Copy link
Member

@phrdang phrdang commented Jul 14, 2020

Updated instructions for Add All the Way and Up 2 Fifty

@phrdang phrdang requested review from a team and Patel-Dev and removed request for a team July 14, 2020 02:51
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No linting violations have been found in this PR.

@phrdang phrdang dismissed github-actions[bot]’s stale review July 14, 2020 02:52

It said no linting violations were found...?

@phrdang phrdang requested review from a team and abhatia1205 and removed request for a team July 14, 2020 02:52
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No linting violations have been found in this PR.

@abhatia1205
Copy link
Contributor

Fix watever the linting error is @phrdang

@phrdang
Copy link
Member Author

phrdang commented Jul 14, 2020

Fix watever the linting error is @phrdang

Yeah I fixed the workflow so Lintly works properly. As for the flake8 lint, when the last PR went in, it caught these errors:
Screen Shot 2020-07-14 at 10 05 07 AM
So I split the long lines into mutliple lines, but then the Black formatter put them back in one line so I was just like eh whatever.
So now the flake8 workflow will only fail on new errors, which is why all the checks should now pass. Not sure if it automatically can un-request changes...

@phrdang
Copy link
Member Author

phrdang commented Jul 14, 2020

Okay @abhatia1205 on second thought I can make it so that Black does max line length of 79 like what flake8 is doing. Hold on a sec...

@phrdang phrdang dismissed github-actions[bot]’s stale review July 14, 2020 17:14

Line length is fine now

@phrdang
Copy link
Member Author

phrdang commented Jul 14, 2020

Alright @abhatia1205 @Patel-Dev should be good now for the Python checks

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No linting violations have been found in this PR.

Copy link

@Patel-Dev Patel-Dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@phrdang phrdang merged commit f97ea7a into master Jul 15, 2020
@phrdang phrdang deleted the fix-typos branch July 15, 2020 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants