Kc req changes #43
Kc req changes #43
Conversation
Added an example and other changes to improve understanding of the problem.
Added an example and other changes to improve understanding of the problem. Didn't change the actual solution other than removing the use of functions.
Made the characters per line less in practice/alternating
Added my solution to alternating.py. I didn't make this problem. Good problem though.
Citrus716
requested review from
abhatia1205,
neha-peddinti,
phrdang and
srikar-eranky
srikar-eranky
left a comment
srikar-eranky
left a comment
There was a problem hiding this comment.
For alternating.py, you might want to convert the alternating numbers into a list, or print them all out on the same line, just to make the output look a bit cleaner. Other than that, I have no issues with these problems or solutions.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Lintly has detected code quality issues in this pull request.
There was a problem hiding this comment.
@abhatia1205 Please see my comments for what needs to be changed. Overall, I think adding more comments would be helpful and also please see the error I received (does it work on your computer? Maybe I'm doing something wrong...)
phrdang
dismissed
github-actions[bot]’s stale review
Outdated, Black fixed it already
There was a problem hiding this comment.
Lintly has detected code quality issues in this pull request.
Adding the comment noqa: [error code] ignores only that line for flake8.
Lintly only supports PRs
I read that PIL is dead and hasn't been updated since 2009. To get "PIL" you must pip install pillow because that's the new name. However, when you import, the code is import PIL in order to allow for backward compatibility. Anyways, I made the instructions to install the libraries.
There was a problem hiding this comment.
Lintly has detected code quality issues in this pull request.
Copy pasted from my instructions I added in practice.
Swapped i and j descriptions and added more. The i represents top to bottom(height) while the j represents left to right(width).
There was a problem hiding this comment.
Lintly has detected code quality issues in this pull request.
|
This PR is really old. Is it still valid? |
|
Yeah so I just looked at it and it's still valid since main's img_avg solution doesn't work |
|
Unfortunately, neither does this branch's img_avg solution |
chrehall68
dismissed
github-actions[bot]’s stale review
obsolete 'changes requested' from linting which now passes
|
Alright I fixed it. Now, it works. This is much better compared with the dysfunctional version that we have on main branch. |
The bug was that the averages were slightly off because I forgot to set y_relative_indexes to an empty list (which I now did, which is why it's now fixed)
Opened by Ke Hao Chen
This pr provides a solution for alternating.py (which apparently had a practice problem but no solution in the main branch). It also fixes img_avg.py's solution to actually work. Lastly, it adds a bit more instruction to img_avg.py to clarify what an image (in list form) would look like.